[18.0][MIG] base_tier_validation_formula: Migration to 18.0 #1021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* [ADD] Basic structure for the new date range module * [IMP] Add a basic description into the README * [IMP] Basic implementation * [IMP] First working implementation * [IMP] Improve datamodel * [ADD] Add basic tests for date.range * [PEP8] * [PYLINT] * [DEL] Remove unused code * [IMP] Remove unsused dependencies into the JS * [IMP] Better operator label for date range * [DEL] Remove unused file * [IMP] Better user experience by showing the select input only once empty * [FIX]Try to fix tests that fails only on travis by adding an explicit cast on the daterange methods parameters * [FIX]Try to fix tests that fails only on travis by adding an explicit cast on the daterange methods parameters * [FIX]Try to fix tests that fails only on travis by using postgresql 9.4 * [FIX]Try with postgresql 9.2 since the daterange method has appeared in 9.2 * [IMP] Add a limitation into the module description to warm about the minimal version of postgresql to use * [IMP]Add multi-company rules * [IMP]Remove unused files * [FIX] Add missing brackets into JS * [FIX] Overlap detection when company_id is False * [IMP] Add default order for date.range * [IMP] Add date range generator * [FIX] OE compatibility * [FIX] Travis * [IMP] Code cleanup and improves test coverage * [FIX] Add missing dependency on 'web' * [PYLINT] remove unused import * [FIX] Add missing copyright * [FIX] Limits are included into the range * [IMP][date_range] Security * [IMP] Improve module description * [IMP] Spelling
* Improve 'name' for generator wizard ir.rule should be active by default * Don't auto-add '-' after prefix when generating date ranges via wizard * code fine tuning suggested by Sylvain Garancher
If any module adds a required field on company, module fails. Executing it on post_install, there's no problem.
Pylint-odoo is not able to detect properly whitelisted odoo's dependencies if an isort configuration file is present into the directory. Therefore the check fails by complaining that the dateutil dependecy is not declared into the manifest. A fix could have been to declare the dependency into the manifest . Unfortunately, in this case, a warning will be issued by runbot complaining that the python external dependency dateutil should be replaced by it's PyPI package name. Unfortunalely, if we put the Pypi package name into the external dependencies, pylint fails again since it's not able to play with PyPI distribution names. The workaround is to temporarily disable this check into pylint. I every case, all the pre-commit files will be reset once pylint will be fixed
We can't assign an empty recordset in a computed writable for a required field for
triggering DB fault, as previously this we get an akward error no in current
ORM status:
ERROR: operator does not exist: integer = boolean
LINE 12: AND dt.type_id=false;
^
HINT: No operator matches the given name and argument types. You might need to add explicit type casts.
so let's simply trigger in this case the check of the company consistency, which is
legit and the final expected result.
I have added an extra test for testing the company consistency the other way around.
Because ev.target.value is a string and the range ids are integers, comparison was always false, so the first range values were always used.
Currently translated at 100.0% (15 of 15 strings) Translation: server-ux-14.0/server-ux-14.0-base_tier_validation_formula Translate-URL: https://translation.odoo-community.org/projects/server-ux-14-0/server-ux-14-0-base_tier_validation_formula/es/
[UPD] Update base_tier_validation_formula.pot
carlos-lopez-tecnativa
suggested changes
Feb 7, 2025
There was a problem hiding this comment.
Tested locally and working. I left a few comments to improve the code, mainly.
Additionally, please squash some of the administrative commits according to this guide
TT54137
@Tecnativa @pedrobaeza @sergio-teruel
carlos-lopez-tecnativa
approved these changes
Feb 10, 2025
absal-smile
force-pushed
the
18.0-mig-base_tier_validation_formula
branch
from
fed607e to
27bd36e
Compare
carlos-lopez-tecnativa
approved these changes
Feb 12, 2025
There was a problem hiding this comment.
LGTM
ping @pedrobaeza @bosd could you please review this?, thanks in advance!
|
/ocabot migration base_tier_validation_formula |
|
@absal-smile Could you please rebase the branch to resolve the test error? This issue was fixed in commit e5f77d0 |
|
This PR has the |
|
@absal-smile please check if the rebase was done correctly. I see many commits related to other modules. |
- Include context keys for avoiding mail operations overhead.
absal-smile
force-pushed
the
18.0-mig-base_tier_validation_formula
branch
from
3ac55ca to
ec8abd7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.