[17.0] [FIX] base_tier_validation: Fixed readonly behavior of fields. #1055
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @LoisRForgeFlow, |
NachoAlesLopez
changed the title
NachoAlesLopez
force-pushed
the
17.0-fix-base_tier_validation-computed_fields
branch
from
dac4717 to
05dc3c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The module
base_tier_validationbehaves strangely when computed fields are present. For example, the following screenshots come from a base installation of Odoo with thesale_tier_validationandsale_purchasemodule added, which causes the purchase order count to be editable when inside a smartbutton:Or, when paired with the
sale_marginmodule, it allows the editing of the margin when the field should be read-only:This is because the base module doesn't take into account the read-onliness of the fields, especially computed fields. This PR should fix that behavior and add a test case to ensure the cases shown before remain patched.