[18.0][IMP] base_tier_validation: support res.groups in addition to res.users in field-based validation #1081
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @LoisRForgeFlow, |
kevinkhao
changed the title
kevinkhao
force-pushed
the
18.0-base_tier_validation_group
branch
from
7e58ca6 to
6425290
Compare
kevinkhao
force-pushed
the
18.0-base_tier_validation_group
branch
from
6425290 to
b0a4f98
Compare
kevinkhao
force-pushed
the
18.0-base_tier_validation_group
branch
2 times, most recently
from
0e382fc to
f9db455
Compare
| return self.env["res.users"] | ||
|
|
||
| def _check_reviewers(self, resource): | ||
| if not resource or resource._name not in ["res.users", "res.groups"]: |
There was a problem hiding this comment.
You don't actually seem to pass groups here. Shouldn't resource always be res.users?
There was a problem hiding this comment.
@kevinkhao Just a reminder that this review is still pending to attend
There was a problem hiding this comment.
right! @StefanRijnhart fixed/mini refactored here cc064b5
LoisRForgeFlow
changed the title
…rs in field-based validation
kevinkhao
force-pushed
the
18.0-base_tier_validation_group
branch
from
9f96b57 to
cc064b5
Compare
| if reviewer_field_val._name == "res.users": | ||
| res = reviewer_field_val | ||
| if not res: | ||
| raise ValidationError( |
There was a problem hiding this comment.
Can you add a line in your test to check this error can be raised successfully? Should make codecov happy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.