Skip to content

[16.0][IMP] base_tier_validation: Make the validation_status field store so that it can be used in searchs. #1084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 16.0
Choose a base branch
from

Conversation

victoralmau
Copy link
Member

@victoralmau victoralmau commented May 22, 2025

Make the validation_status field store so that it can be used in searchs.

Please @pedrobaeza and @carlos-lopez-tecnativa can you review it?

@Tecnativa TT56391

@victoralmau victoralmau force-pushed the 16.0-imp-base_tier_validation-TT56391 branch 2 times, most recently from 83cffa6 to e9cdb74 Compare May 23, 2025 06:06
Copy link

@carlos-lopez-tecnativa carlos-lopez-tecnativa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, LGTM. I only think that recomputing these fields to be stored might take a lot of time on databases with a lot of data.

@pedrobaeza pedrobaeza added this to the 16.0 milestone May 26, 2025
@pedrobaeza
Copy link
Member

Yes, including this at this stage makes the update very slow. The search approach avoids this, but not sure if it's doable.

@victoralmau
Copy link
Member Author

Another possibility is to add migration scripts so that this change is not slow. Adding the store fields I think is useful, although you will need the migration scripts when they are done. I work on them a bit to avoid this inconvenience.

@victoralmau victoralmau force-pushed the 16.0-imp-base_tier_validation-TT56391 branch 2 times, most recently from 1ca175d to e55af97 Compare May 27, 2025 08:10
@victoralmau victoralmau force-pushed the 16.0-imp-base_tier_validation-TT56391 branch from e55af97 to 23178dd Compare June 30, 2025 07:57
@victoralmau victoralmau force-pushed the 16.0-imp-base_tier_validation-TT56391 branch from 23178dd to d36753a Compare July 1, 2025 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants