[18.0][FIX] base_tier_validation: fix reviewer field check #1089
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @LoisRForgeFlow, |
mmequignon
force-pushed
the
18.0-base-tier-validation-fix_reviewer_field_check
branch
from
1e22859 to
3a4a4c9
Compare
There was a problem hiding this comment.
@mmequignon are going to finish this? If so, remember to add test cases.
mmequignon
force-pushed
the
18.0-base-tier-validation-fix_reviewer_field_check
branch
from
3a4a4c9 to
b095316
Compare
done |
mmequignon
force-pushed
the
18.0-base-tier-validation-fix_reviewer_field_check
branch
from
b095316 to
55424e5
Compare
mmequignon
force-pushed
the
18.0-base-tier-validation-fix_reviewer_field_check
branch
from
55424e5 to
ab4a4ef
Compare
mmequignon
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Raises a misleading exception when reviewer field is correctly set, but is empty on the record.
Put this as draft / WIP as there's another exception raised once this is fixed that I need to tackle next.