[18.0][MIG] announcement_dialog_size: Migration to version 18.0 #1100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Now that the reads count is stored, we need to add a depends that triggers the recomputation. To do so, we need to link announcements and read logs. - Simplified popup on log in mechanism. - The notification_expiry_date field was duplicated in the form view - Add some thechnical suggestions - Change the term `pendant` to a more convenient `unread` - Regular users can't read announcements with dates in the future or which expiration date has passed nor archived announcements. - Fix typos TT38174
If a user has an announcement open in multiple windows, the read will be logged multiple times. The relevant one is only the first one. TT38705
There's a soft compatibility with OCA's `web_dialog_size` module. If the instance has the module installed, you'll have the dialog resize controls by default in the announcements. Additionally, you can show the announcement dialogs expanded to the screen full width by default setting the system parameter key `announcement.full_size` with to any value. Remove the parameter record to disable this behavior. TT39634
Currently translated at 100.0% (52 of 52 strings) Translation: server-ux-15.0/server-ux-15.0-announcement Translate-URL: https://translation.odoo-community.org/projects/server-ux-15-0/server-ux-15-0-announcement/es/
A new field "is_general_announcement" is added which when checked sends the announcement to users belonging to the "Internal User" group. TT42581
A new field has been added to be able to attach files to the announcement, and these attachments will be displayed in the announcement notification modal. TT42581
Doing them to be owned by the record.
Example of use case: - Create an announcement to a user - Archive the user - When accessing the advertisement, we want to know the user(s) even if he/she is now archived. TT49077
Currently translated at 100.0% (76 of 76 strings) Translation: server-ux-17.0/server-ux-17.0-announcement Translate-URL: https://translation.odoo-community.org/projects/server-ux-17-0/server-ux-17-0-announcement/it/
…ment_dialog fullsized
Currently translated at 100.0% (1 of 1 strings) Translation: server-ux-16.0/server-ux-16.0-announcement_dialog_size Translate-URL: https://translation.odoo-community.org/projects/server-ux-16-0/server-ux-16-0-announcement_dialog_size/it/
|
I think that this glue module is not needed anymore. Installing announcement and web_dialog_size I can resize the announcement dialog. The only reason I would keep this module is if there were a need to set the dialog size independently from the others in Odoo. But from my point of view, I don't see it as necessary. Maybe @pedrobaeza or @victoralmau can tell us if this is the actual purpose of the module. |
|
@CarlosRoca13 the need was if you have the parameter set for expanding by default. Is that being respected? Anyway, check in the customer instance if it's set, because maybe we don't need it anyway. |
|
Yes, right now it is respected, and our customer instance have not set the parameter. So this module is definitely not necessary |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on:
@Tecnativa @CarlosRoca13 @pilarvargas-tecnativa
TT55500