[18.0][FIX] base_tier_validation: Proper notifications on reviews #1112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes done: - The subtypes should not be defined as default=True to avoid that a follower receives notifications of everything (even if he/she doesn't really need it). - When adding followers they are added to the corresponding subtype so that the notification arrives to whom it corresponds. - Improve the code so that the reviews to notify are the "following ones according to the sequence". TT56354
|
Hi @LoisRForgeFlow, |
pedrobaeza
approved these changes
Jul 1, 2025
|
/ocabot merge major |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at 393c96c. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FWP from 17.0: #1111
Proper notifications on reviews
Changes done:
@Tecnativa TT56354