[18.0][FIX] base_tier_validation: make ReviewsTable widget work with manual config #1117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
config When an Odoo model inherits from `tier.validation` but sets up `_tier_validation_manual_config = True`, adding `review_ids` in a form view with the `tier_validation` widget causes Owl errors. It appears that the Tier Review fields are then not passed to the Owl framework, and accessing them in the widget template raises exceptions. Adding the fields used in the `base_tier_validation.Collapse` template to the component under the `relatedFields` key fixes this, while not changing the behavior for models using `_tier_validation_manual_config = False`.
|
Hi @LoisRForgeFlow, |
MaxyMoos
changed the title
LoisRForgeFlow
approved these changes
Jul 2, 2025
|
/ocabot merge patch |
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at 346c206. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forward-port of #1093 , since the original issue can be reproduced in v18 too.