[18.0][MIG] chained_swapper: Migration to version 18.0 #1123
Conversation
|
/ocabot migration chained_swapper |
| allowed_field_ids = fields.Many2many( | ||
| comodel_name="ir.model.fields", compute="_compute_allowed_field_ids" | ||
| ) |
There was a problem hiding this comment.
I think this can be reimplemented as a Binary field, and a many2many is not necessary.
Please check an example here:
https://github.com/odoo/odoo/blob/2d2faa413abd48e80c166c384eeede6b99843973/addons/account/models/account_tax.py#L2907
https://github.com/odoo/odoo/blob/2d2faa413abd48e80c166c384eeede6b99843973/addons/account/views/account_tax_views.xml#L47
There was a problem hiding this comment.
i don't understand the point of this
There was a problem hiding this comment.
Done! Can you check if it's correct? Thanks!
juancarlosonate-tecnativa
force-pushed
the
18.0-mig-chained_swapper
branch
from
7a5ffa4 to
05d4fa7
Compare
…revent warning log
juancarlosonate-tecnativa
force-pushed
the
18.0-mig-chained_swapper
branch
2 times, most recently
from
07cba65 to
4d75eca
Compare
juancarlosonate-tecnativa
force-pushed
the
18.0-mig-chained_swapper
branch
from
4d75eca to
9b00045
Compare
There was a problem hiding this comment.
LGTM. I left a few comments that I think could help improve the UI/UX. If you have any questions, feel free to let me know.
@pedrobaeza could this be improved in this PR, What do you think?
| body = Markup( | ||
| self.env._("<b>Chained swap done</b>:<br/>%(field)s: %(old)s ⇒ %(new)s") | ||
| ) % { | ||
| "field": field_desc, | ||
| "old": original_value, | ||
| "new": new_value, | ||
| } | ||
| m.message_post(body=body) |
There was a problem hiding this comment.
| body = Markup( | |
| self.env._("<b>Chained swap done</b>:<br/>%(field)s: %(old)s ⇒ %(new)s") | |
| ) % { | |
| "field": field_desc, | |
| "old": original_value, | |
| "new": new_value, | |
| } | |
| m.message_post(body=body) | |
| body = Markup( | |
| self.env._("<b>Chained swap done</b>:<br/>%(field)s: %(old)s ⇒ %(new)s", | |
| field=field_desc, | |
| old=original_value, | |
| new=new_value, | |
| ) | |
| } | |
| m.message_post(body=body) |
| <field name="model">chained.swapper.sub.field</field> | ||
| <field name="arch" type="xml"> | ||
| <list editable="bottom"> | ||
| <field name="sub_field_chain" /> |
There was a problem hiding this comment.
This way of selecting the field is anti-ergonomic. Could you please use the DynamicModelFieldSelectorChar widget?
An example can be found in server actions when using Update Records. This widget allows navigating through all fields and is more user-friendly.
| <page string="Constraints"> | ||
| <field name="constraint_ids" nolabel="1" /> | ||
| </page> |
There was a problem hiding this comment.
Could you improve the help message to explain all the available variables?
Something similar to what is shown in Server Actions when using the Execute Code option.
@Tecnativa TT54143
@pedrobaeza @carlos-lopez-tecnativa