-
-
Notifications
You must be signed in to change notification settings - Fork 583
[15.0][ADD] web_hide_custom_search #1124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 15.0
Are you sure you want to change the base?
[15.0][ADD] web_hide_custom_search #1124
Conversation
8b96711
to
1570873
Compare
Shouldn't it start with |
1570873
to
d2abed9
Compare
2632ae1
to
c9371c6
Compare
c9371c6
to
b6e3319
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Partial review.
Module name suggestion: web_hide_custom_search
Sorry, I just came to think that 'custom search' would cover both filter and group-by.
c382341
to
5476066
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM. Could we add tests?
patch(CustomFilterItem.prototype, "web_hide_custom_search.CustomFilterItemPatch", { | ||
setup() { | ||
this._super.apply(this, arguments); | ||
this.visibleState = useState({isVisible: true}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This may be more in line with the usual convention?
this.visibleState = useState({isVisible: true}); | |
this.state = useState({isVisible: true}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked using state, but since it's initialized inside the constructor, even if we try to add visible inside setup(), it only contains the original initialized value. So, I’ll just use a new variable instead.
5476066
to
338b985
Compare
This module allows controlling the visibility of the “Add Custom Filter” and “Add Custom Group” options in the search view for specific models and specific user groups.
@qrtl QT4975