Skip to content

[18.0][MIG] default_multi_user: Migration to 18.0 #1130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 27 commits into from
Aug 6, 2025

Conversation

ArnauCForgeFlow
Copy link
Contributor

Standard Migration to version 18.0

LoisRForgeFlow and others added 26 commits July 28, 2025 11:18
is incorrect to relay in the company_id field in the res_users
table, we should use environment company instead.
Currently translated at 100.0% (8 of 8 strings)

Translation: server-ux-14.0/server-ux-14.0-default_multi_user
Translate-URL: https://translation.odoo-community.org/projects/server-ux-14-0/server-ux-14-0-default_multi_user/es/
Currently translated at 100.0% (8 of 8 strings)

Translation: server-ux-14.0/server-ux-14.0-default_multi_user
Translate-URL: https://translation.odoo-community.org/projects/server-ux-14-0/server-ux-14-0-default_multi_user/pt/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: server-ux-15.0/server-ux-15.0-default_multi_user
Translate-URL: https://translation.odoo-community.org/projects/server-ux-15-0/server-ux-15-0-default_multi_user/
This was fixed upstream but the signature of the method never got
updated here in the corresponding hook.
Copy link
Contributor

@LoisRForgeFlow LoisRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When migrating modules with hooks that modify original methods, you need to make sure that nothing is changes apart from what's strictly the purpose (in this case highlighted with comments # START/END OF CHANGES. Apart from that there is no intention of modifying the orignal method. In v18 the method changed slightly, and that change needs to be also included here: https://github.com/odoo/odoo/blob/18.0/odoo/addons/base/models/ir_default.py#L159

@ArnauCForgeFlow ArnauCForgeFlow force-pushed the 18.0-mig-default_multi_user branch from f0c8d95 to 9229b35 Compare July 29, 2025 08:09
@ArnauCForgeFlow
Copy link
Contributor Author

@LoisRForgeFlow Done!

Copy link
Contributor

@LoisRForgeFlow LoisRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review, works as expected 👍

@LoisRForgeFlow
Copy link
Contributor

/ocabot migration default_multi_user

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone Aug 6, 2025
@OCA-git-bot OCA-git-bot mentioned this pull request Aug 6, 2025
26 tasks
Copy link
Contributor

@JasminSForgeFlow JasminSForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

@LoisRForgeFlow
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 18.0-ocabot-merge-pr-1130-by-LoisRForgeFlow-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit f3bb8f4 into OCA:18.0 Aug 6, 2025
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at fa69717. Thanks a lot for contributing to OCA. ❤️

@MiquelRForgeFlow MiquelRForgeFlow deleted the 18.0-mig-default_multi_user branch August 6, 2025 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants