-
-
Notifications
You must be signed in to change notification settings - Fork 586
[18.0][MIG] default_multi_user: Migration to 18.0 #1130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
is incorrect to relay in the company_id field in the res_users table, we should use environment company instead.
Currently translated at 100.0% (8 of 8 strings) Translation: server-ux-14.0/server-ux-14.0-default_multi_user Translate-URL: https://translation.odoo-community.org/projects/server-ux-14-0/server-ux-14-0-default_multi_user/es/
Currently translated at 100.0% (8 of 8 strings) Translation: server-ux-14.0/server-ux-14.0-default_multi_user Translate-URL: https://translation.odoo-community.org/projects/server-ux-14-0/server-ux-14-0-default_multi_user/pt/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-ux-15.0/server-ux-15.0-default_multi_user Translate-URL: https://translation.odoo-community.org/projects/server-ux-15-0/server-ux-15-0-default_multi_user/
This was fixed upstream but the signature of the method never got updated here in the corresponding hook.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When migrating modules with hooks that modify original methods, you need to make sure that nothing is changes apart from what's strictly the purpose (in this case highlighted with comments # START/END OF CHANGES
. Apart from that there is no intention of modifying the orignal method. In v18 the method changed slightly, and that change needs to be also included here: https://github.com/odoo/odoo/blob/18.0/odoo/addons/base/models/ir_default.py#L159
f0c8d95
to
9229b35
Compare
@LoisRForgeFlow Done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional review, works as expected 👍
/ocabot migration default_multi_user |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
/ocabot merge nobump |
On my way to merge this fine PR! |
Congratulations, your PR was merged at fa69717. Thanks a lot for contributing to OCA. ❤️ |
Standard Migration to version 18.0