Skip to content

[18.0][FIX] base_tier_validation: Prevent errors in migration script #1139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

carlos-lopez-tecnativa
Copy link
Contributor

Odoo in V18 raises an error if the signature of the function is not strictly (cr, version). See: https://github.com/odoo/odoo/blob/2a839ef1ed09c36f27ce7536ca3052d9f65ceed9/odoo/modules/migration.py#L252-L256

This solves the error reported in: #1138 (review)

@Tecnativa @pedrobaeza @victoralmau @StefanRijnhart could you please review this?

@OCA-git-bot
Copy link
Contributor

Hi @LoisRForgeFlow,
some modules you are maintaining are being modified, check this out!

@pedrobaeza pedrobaeza added this to the 18.0 milestone Aug 7, 2025
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is Odoo trying to prevent openupgradelib?

@pedrobaeza pedrobaeza merged commit ba87132 into OCA:18.0 Aug 7, 2025
7 checks passed
@pedrobaeza pedrobaeza deleted the 18.0-fix-base_tier_validation-migration-script branch August 7, 2025 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants