Skip to content

[15.0][MIG] base_user_locale #471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Dec 11, 2023
Merged

[15.0][MIG] base_user_locale #471

merged 19 commits into from
Dec 11, 2023

Conversation

ChrisOForgeFlow
Copy link
Contributor

Standard Migration
@ForgeFlow

@ChrisOForgeFlow ChrisOForgeFlow force-pushed the 15.0-mig-base_user_locale branch from 2a7f6f2 to 0d65453 Compare March 15, 2022 15:27
@alexey-pelykh
Copy link
Contributor

@ChrisOForgeFlow may I ask you to include also 4ce86c7 ?

@alexey-pelykh
Copy link
Contributor

And squash last two commits so that migration is done within one commit as per guidelines

@ChrisOForgeFlow ChrisOForgeFlow force-pushed the 15.0-mig-base_user_locale branch 2 times, most recently from 8b23e6b to 9b3d984 Compare July 28, 2022 13:16
@ChrisOForgeFlow
Copy link
Contributor Author

@alexey-pelykh is done, thanks!

@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Nov 27, 2022
@JuanyDForgeflow
Copy link

@ChrisOForgeFlow please rebase, runboat isn't working

alexey-pelykh and others added 17 commits December 13, 2022 15:59
@alexey-pelykh @ChrisOForgeFlow
[ADD] base_user_locale: configure locale settings
d44b3c1
@oca-travis @ChrisOForgeFlow
[UPD] Update base_user_locale.pot
ead4efd
@OCA-git-bot @ChrisOForgeFlow
[UPD] README.rst
b8ff24e
@OCA-git-bot @ChrisOForgeFlow
[ADD] icon.png
7ed7ca8
@Tonow-c2c @ChrisOForgeFlow
[IMP] base_user_locale: black, isort, prettier
b9dd431
@Tonow-c2c @ChrisOForgeFlow
[MIG] base_user_locale: Migration to 13.0
e8dd922
@MiquelRForgeFlow @ChrisOForgeFlow
[MIG] base_user_locale: migration continuation
1ba7325
@MiquelRForgeFlow @ChrisOForgeFlow
[IMP] base_user_locale: add decimal_point and thousands_sep
19e0fbb
@LoisRForgeFlow @ChrisOForgeFlow
[FIX] base_user_locale: wrong method signature and force reload
41e59cf 
of settings to apply locale preferences of the user.

Also update readme.
@oca-travis @ChrisOForgeFlow
[UPD] Update base_user_locale.pot
808aa69
@OCA-git-bot @ChrisOForgeFlow
[UPD] README.rst
3b29a98
@GuillemCForgeFlow @ChrisOForgeFlow
[14.0][MIG]base_user_locale: Migration to 14.0
06a8ada
@oca-travis @ChrisOForgeFlow
[UPD] Update base_user_locale.pot
419446b
@OCA-git-bot @ChrisOForgeFlow
[UPD] README.rst
a426b56
@JordiMForgeFlow @ChrisOForgeFlow
[FIX] base_user_locale: make new fields readable for user
a85ffed
@OCA-git-bot @ChrisOForgeFlow
base_user_locale 14.0.1.1.0
027c225
@ChrisOForgeFlow
[IMP] base_user_locale: black, isort, prettier
26a7a6f
@ChrisOForgeFlow ChrisOForgeFlow force-pushed the 15.0-mig-base_user_locale branch from 3b27068 to f306493 Compare December 13, 2022 21:00
@ChrisOForgeFlow ChrisOForgeFlow force-pushed the 15.0-mig-base_user_locale branch from f306493 to 5a2c1dc Compare December 13, 2022 22:18
LoisRForgeFlow
LoisRForgeFlow requested changes Dec 14, 2022
View reviewed changes
Copy link
Contributor

@LoisRForgeFlow LoisRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does not work in my functional test on runboat:

image

image

Do I miss something?

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Dec 18, 2022
@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Apr 23, 2023
@github-actions github-actions bot closed this May 28, 2023
@LoisRForgeFlow LoisRForgeFlow added no stale Use this label to prevent the automated stale action from closing this PR/Issue. and removed stale PR/Issue without recent activity, it'll be soon closed automatically. labels May 29, 2023
@JordiBForgeFlow JordiBForgeFlow mentioned this pull request Dec 8, 2023
Merged
@JordiBForgeFlow
Copy link
Member

@LoisRForgeFlow Please follow the instructions in #780 to test

@LoisRForgeFlow
Copy link
Contributor

@LoisRForgeFlow Please follow the instructions in #780 to test

Thanks!

LoisRForgeFlow
LoisRForgeFlow approved these changes Dec 11, 2023
View reviewed changes
Copy link
Contributor

@LoisRForgeFlow LoisRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing in a incognito window did the trick and I was able to validate the functionality

LGTM

/ocabot merge nobump

@LoisRForgeFlow
Copy link
Contributor

/ocabot migration base_user_locale

@OCA-git-bot OCA-git-bot added this to the 15.0 milestone Dec 11, 2023
@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 15.0-ocabot-merge-pr-471-by-LoisRForgeFlow-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot mentioned this pull request Dec 11, 2023
Closed
34 tasks
@OCA-git-bot OCA-git-bot merged commit c715d44 into OCA:15.0 Dec 11, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at d67f810. Thanks a lot for contributing to OCA. ❤️

@MiquelRForgeFlow MiquelRForgeFlow deleted the 15.0-mig-base_user_locale branch December 11, 2023 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexey-pelykh alexey-pelykh alexey-pelykh approved these changes

@JordiBForgeFlow JordiBForgeFlow JordiBForgeFlow approved these changes

@LoisRForgeFlow LoisRForgeFlow LoisRForgeFlow approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 no stale Use this label to prevent the automated stale action from closing this PR/Issue.
Projects
None yet
Milestone
15.0
Development

Successfully merging this pull request may close these issues.