Skip to content

[15.0][FIX] mass_editing: fix error test #773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 24, 2023

Conversation

pilarvargas-tecnativa
Copy link
Contributor

@pilarvargas-tecnativa pilarvargas-tecnativa commented Nov 24, 2023

The exception was not being captured correctly.

2023-11-24 12:05:49,413 1 INFO devel odoo.addons.mass_editing.tests.test_mass_editing: Starting TestMassEditing.test_mass_edit_partner_sql_error ... 
2023-11-24 12:05:49,552 1 INFO devel odoo.tests: skip sending email in test mode 
2023-11-24 12:05:49,553 1 INFO devel odoo.addons.mail.models.mail_mail: Mail with ID 8 and Message-Id '<060011745599214.1700827549.524634122848511-openerp-11-res.users@b50d18bbc02d>' successfully sent 
2023-11-24 12:05:49,557 1 INFO devel odoo.models.unlink: User #1 deleted mail.mail records with IDs: [8] 
2023-11-24 12:05:49,563 1 INFO devel odoo.models.unlink: User #1 deleted mail.message records with IDs: [214] 
2023-11-24 12:05:49,563 1 INFO devel odoo.addons.mail.models.mail_mail: Sent batch 1 emails via mail server ID #False 
2023-11-24 12:05:49,567 1 INFO devel odoo.addons.auth_signup.models.res_users: Password reset email sent for user <test-mass_editing-user> to <[email protected]> 
2023-11-24 12:05:49,600 1 WARNING devel root: write_record_by_record: True 
2023-11-24 12:05:49,603 1 ERROR devel odoo.sql_db: bad query: UPDATE "res_partner" SET "commercial_partner_id"=48,"type"='contact',"write_date"='2023-11-24T12:05:48.684037'::timestamp,"write_uid"=1 WHERE id IN (48)
ERROR: new row for relation "res_partner" violates check constraint "res_partner_check_name"
DETAIL:  Failing row contains (48, null, null, 2023-11-24 12:05:48.684037, null, null, null, null, null, en_US, null, null, null, null, null, null, t, null, null, contact, null, null, null, null, null, null, null, null, null, null, null, f, null, 0, null, 48, null, null, 1, 1, 2023-11-24 12:05:48.684037, null, null, 0, null, null, null, null, null, null, null, null, no-message, null, 0, 0).
 
2023-11-24 12:05:49,604 1 ERROR devel odoo.sql_db: bad query: SELECT value FROM ir_translation
                       WHERE lang='en_US' AND type in ('code') AND src='Failed to process the %(model_name)s  "%(name)s" [id: %(id)s]:

%(ue)s' AND md5(src)=md5('Failed to process the %(model_name)s  "%(name)s" [id: %(id)s]:

%(ue)s')
ERROR: current transaction is aborted, commands ignored until end of transaction block

cc @Tecnativa TT44344

@pedrobaeza @victoralmau please review :)

The exception was not being captured correctly.

TT44344
@pedrobaeza pedrobaeza added this to the 15.0 milestone Nov 24, 2023
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 15.0-ocabot-merge-pr-773-by-pedrobaeza-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Nov 24, 2023
Signed-off-by pedrobaeza
@OCA-git-bot
Copy link
Contributor

@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 15.0-ocabot-merge-pr-773-by-pedrobaeza-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@pedrobaeza
Copy link
Member

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 15.0-ocabot-merge-pr-773-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit f0186cc into OCA:15.0 Nov 24, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 7dbca55. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 15.0-fix-mass_editing-test branch November 24, 2023 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants