Skip to content

[15.0][FIX] base_tier_validation: Change web_ribbon text to title to make it translatable#812

Merged
OCA-git-bot merged 1 commit intoOCA:15.0from
Tecnativa:15.0-fix-base_tier_validation-web_ribbon
Jan 30, 2024
Merged

[15.0][FIX] base_tier_validation: Change web_ribbon text to title to make it translatable#812
OCA-git-bot merged 1 commit intoOCA:15.0from
Tecnativa:15.0-fix-base_tier_validation-web_ribbon

Conversation

@victoralmau
Copy link
Member

@victoralmau victoralmau commented Jan 29, 2024

Change web_ribbon text to title to make it translatable

@Tecnativa

@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Jan 29, 2024

Hi @LoisRForgeFlow,
some modules you are maintaining are being modified, check this out!

@pedrobaeza pedrobaeza added this to the 15.0 milestone Jan 29, 2024
pedrobaeza
pedrobaeza requested changes Jan 29, 2024
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better to not mix translation work with other things. Keep the PR with the minimum XML change

@victoralmau victoralmau force-pushed the 15.0-fix-base_tier_validation-web_ribbon branch from 0603a3f to 7240c77 Compare January 30, 2024 07:19
@victoralmau
Copy link
Member Author

victoralmau commented Jan 30, 2024

Changes done.

pedrobaeza
pedrobaeza approved these changes Jan 30, 2024
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Jan 30, 2024

This PR looks fantastic, let's merge it!
Prepared branch 15.0-ocabot-merge-pr-812-by-pedrobaeza-bump-minor, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Jan 30, 2024
@OCA-git-bot
Merge PR #812 into 15.0
8372d4f 
Signed-off-by pedrobaeza
@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Jan 30, 2024

@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 15.0-ocabot-merge-pr-812-by-pedrobaeza-bump-minor.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@pedrobaeza
Copy link
Member

pedrobaeza commented Jan 30, 2024

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Jan 30, 2024

This PR looks fantastic, let's merge it!
Prepared branch 15.0-ocabot-merge-pr-812-by-pedrobaeza-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 269cae0 into OCA:15.0 Jan 30, 2024
@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Jan 30, 2024

Congratulations, your PR was merged at ef4f2f5. Thanks a lot for contributing to OCA. ❤️

@victoralmau victoralmau mentioned this pull request Jan 30, 2024
Merged
@pedrobaeza pedrobaeza deleted the 15.0-fix-base_tier_validation-web_ribbon branch January 30, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pedrobaeza pedrobaeza pedrobaeza approved these changes

+1 more reviewer

@chienandalu chienandalu chienandalu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved merged 🎉

Projects

None yet

Milestone

15.0

Development

Successfully merging this pull request may close these issues.

4 participants

@victoralmau @OCA-git-bot @pedrobaeza @chienandalu