[15.0][ADD] web_filter_header_button: New module#840
Closed
chienandalu wants to merge 1 commit intoOCA:15.0from
Closed
[15.0][ADD] web_filter_header_button: New module#840chienandalu wants to merge 1 commit intoOCA:15.0from
chienandalu wants to merge 1 commit intoOCA:15.0from
Conversation
Member
|
It should be called web_filter_button IMO |
chienandalu
force-pushed
the
15.0-add-filter_button
branch
from
2db648e to
1bbaa38
Compare
chienandalu
changed the title
Member
|
The commit message still indicates |
chienandalu
force-pushed
the
15.0-add-filter_button
branch
from
1bbaa38 to
f6b8e1a
Compare
chienandalu
changed the title
Member
|
I think this should be in OCA/web. |
Member
Author
|
What are the nuances for a module to be in |
Member
|
Well, this is a modification of the web client, so we usually put them in oca/web. |
Member
Author
|
Moved to OCA/web#2768 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This module allows to add some selected filters as buttons in the header control panel.
cc @Tecnativa TT47127
@pedrobaeza do you think the name is ok?