Skip to content

[15.0][ADD] web_filter_header_button: New module #840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

chienandalu
Copy link
Member

This module allows to add some selected filters as buttons in the header control panel.

Peek 12-03-2024 13-50

cc @Tecnativa TT47127

@pedrobaeza do you think the name is ok?

@pedrobaeza
Copy link
Member

It should be called web_filter_button IMO

@chienandalu chienandalu force-pushed the 15.0-add-filter_button branch from 2db648e to 1bbaa38 Compare March 12, 2024 13:43
@chienandalu chienandalu changed the title [15.0][ADD] filter_button: New module [15.0][ADD] web_filter_button: New module Mar 12, 2024
@pedrobaeza
Copy link
Member

The commit message still indicates filter_button. Thinking twice, web_filter_header_button may be more specific.

@chienandalu chienandalu force-pushed the 15.0-add-filter_button branch from 1bbaa38 to f6b8e1a Compare March 12, 2024 13:52
@chienandalu chienandalu changed the title [15.0][ADD] web_filter_button: New module [15.0][ADD] web_filter_header_button: New module Mar 12, 2024
@pedrobaeza pedrobaeza added this to the 15.0 milestone Mar 13, 2024
@pedrobaeza
Copy link
Member

I think this should be in OCA/web.

@chienandalu
Copy link
Member Author

What are the nuances for a module to be in server-ux?

@pedrobaeza
Copy link
Member

Well, this is a modification of the web client, so we usually put them in oca/web.

@chienandalu
Copy link
Member Author

Moved to OCA/web#2768

@pedrobaeza pedrobaeza deleted the 15.0-add-filter_button branch March 13, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants