[DOC] date_range: Update broken image links #841
Conversation
|
Hi @lmignon, |
amh-mw
changed the title
There was a problem hiding this comment.
Hi @amh-mw
Thank you for your contrib. The README.rst file is generated from fragments defined into several files located under the readme directory. The right fix is to modify the links into these files. Once done, the README.rst will be generated at merge time. Can you update your PR accordingly?
amh-mw
changed the title
|
@amh-mw you can take this as an example: https://github.com/OCA/server-ux/blob/16.0/template_content_swapper/readme/USAGE.rst?plain=1#L3 |
|
@lmignon I think it's better to use relative paths |
date_range/readme/CONFIGURE.rst
Outdated
| @@ -12,7 +12,7 @@ inherit from `date.range.search.mixin`: | |||
|
|
|||
| This will make a `Period` field show up in the search view: | |||
|
|
|||
| .. figure:: https://raw.githubusercontent.com/OCA/server-tools/12.0/date_range/static/description/date_range_many2one_search_field.png | |||
| .. figure:: https://raw.githubusercontent.com/OCA/server-ux/15.0/date_range/static/description/date_range_many2one_search_field.png | |||
There was a problem hiding this comment.
The correct way to put it and forget about this on each version is to put a relative path, and let the README generator to put the absolute one, but meanwhile, you see the correct image in local devel env.
| .. figure:: https://raw.githubusercontent.com/OCA/server-ux/15.0/date_range/static/description/date_range_many2one_search_field.png | |
| .. figure:: ../static/description/date_range_many2one_search_field.png |
There was a problem hiding this comment.
@pedrobaeza you're right. I just checked the readme generator and relative paths are replaced by the right absolute path at generation.
There was a problem hiding this comment.
LGTM
@amh-mw would you be so kind to open a PR for v16 as well? Thanks!
|
/ocabot merge nobump |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at 3f73626. Thanks a lot for contributing to OCA. ❤️ |
No description provided.