Skip to content

[18.0][MIG] developer_menu: Migration to 18.0 #950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 10, 2024
Merged

[18.0][MIG] developer_menu: Migration to 18.0 #950

merged 5 commits into from
Oct 10, 2024

Conversation

bealdav
Copy link
Member

@bealdav bealdav commented Oct 9, 2024 •
edited
Loading

image

@bealdav bealdav force-pushed the 18.0-mig-developer_menu branch from 1c2b581 to 4cc067f Compare October 9, 2024 13:28
@bealdav bealdav force-pushed the 18.0-mig-developer_menu branch from 4cc067f to ca42a6e Compare October 9, 2024 13:58
@bealdav bealdav mentioned this pull request Oct 9, 2024
Open
30 tasks
@bealdav bealdav force-pushed the 18.0-mig-developer_menu branch from b3a8b53 to 90c0225 Compare October 10, 2024 08:06
@bealdav bealdav marked this pull request as ready for review October 10, 2024 08:13
florian-dacosta
florian-dacosta approved these changes Oct 10, 2024
View reviewed changes
Copy link

@florian-dacosta florian-dacosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM code review

PaulGoubert
PaulGoubert approved these changes Oct 10, 2024
View reviewed changes
Copy link

@PaulGoubert PaulGoubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functiuonnal review Done.
Usefull
LGTM

@bealdav
Copy link
Member Author

bealdav commented Oct 10, 2024

cc @dreispt

houssine78
houssine78 approved these changes Oct 10, 2024
View reviewed changes
Copy link

@houssine78 houssine78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@houssine78
Copy link

@pedrobaeza this one is ready to be merge too.

@pedrobaeza pedrobaeza changed the title [MIG] 18.0 developer menu [18.0][MIG] developer_menu: Migration to 18.0 Oct 10, 2024
pedrobaeza
pedrobaeza reviewed Oct 10, 2024
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please name properly PRs for being found. It's not the first time I tell you about this.

/ocabot migration developer_menu
/ocabot merge nobump

checklog-odoo.cfg
@@ -0,0 +1,3 @@
[checklog-odoo]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure we should disable this at repo level.

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone Oct 10, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Oct 10, 2024
Open
26 tasks
@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 18.0-ocabot-merge-pr-950-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Oct 10, 2024
@OCA-git-bot
Merge PR #950 into 18.0
2b51a70 
Signed-off-by pedrobaeza
@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 18.0-ocabot-merge-pr-950-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit bd6e4bd into OCA:18.0 Oct 10, 2024
5 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 0867747. Thanks a lot for contributing to OCA. ❤️

@bealdav bealdav deleted the 18.0-mig-developer_menu branch October 10, 2024 20:30
@bealdav
Copy link
Member Author

bealdav commented Oct 10, 2024

@pedrobaeza Thanks for this merge.

I don't know how to have a better name ?

image

What's wrong ?

@pedrobaeza
Copy link
Member

That's because I have changed it to the correct one, having the full module name. Please check the log on the conversation to see your old PR title.

@bealdav
Copy link
Member Author

bealdav commented Oct 10, 2024

Hi sorry, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrobaeza pedrobaeza pedrobaeza left review comments

@florian-dacosta florian-dacosta florian-dacosta approved these changes

@houssine78 houssine78 houssine78 approved these changes

@PaulGoubert PaulGoubert PaulGoubert approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
18.0
Development

Successfully merging this pull request may close these issues.
7 participants
@bealdav @houssine78 @OCA-git-bot @pedrobaeza @florian-dacosta @PaulGoubert @mymage