Skip to content

[18.0][MIG] base_cancel_confirm: Migration to 18.0 #972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 30 commits into from
Feb 24, 2025
Merged

[18.0][MIG] base_cancel_confirm: Migration to 18.0 #972

merged 30 commits into from
Feb 24, 2025

Conversation

TheerayutEncoder
Copy link
Member

Standard migration to 18.0

kittiu and others added 28 commits November 21, 2024 13:43
@kittiu @TheerayutEncoder
[14.0][ADD] base_cancel_confirm
46bfb78
@oca-travis @TheerayutEncoder
[UPD] Update base_cancel_confirm.pot
07cad7f
@OCA-git-bot @TheerayutEncoder
[UPD] README.rst
0cf5d51
@bosd @TheerayutEncoder
Added translation using Weblate (Dutch)
ea98a16
@bosd @TheerayutEncoder
Translated using Weblate (Dutch)
6bcf638 
Currently translated at 71.4% (15 of 21 strings)

Translation: server-ux-14.0/server-ux-14.0-base_cancel_confirm
Translate-URL: https://translation.odoo-community.org/projects/server-ux-14-0/server-ux-14-0-base_cancel_confirm/nl/
@kittiu @TheerayutEncoder
[14.0][FIX] base_cancel_confirm, access window action error
1fd855d
@OCA-git-bot @TheerayutEncoder
base_cancel_confirm 14.0.1.0.1
6f1282f
@newtratip @TheerayutEncoder
[14.0][FIX] base_cancel_confirm: No duplicate cancel confirm and canc…
9f647d7 
…el reason
@OCA-git-bot @TheerayutEncoder
base_cancel_confirm 14.0.1.0.2
0ea51ce
@sebalix @TheerayutEncoder
[FIX] Fix access right issues when using actions
eb9e5d1
@OCA-git-bot @TheerayutEncoder
base_cancel_confirm 14.0.1.0.3
88181be
@kittiu @TheerayutEncoder
[IMP] base_cancel_confirm, allow disable cancel confirm
c9a08ef
@TheerayutEncoder
[MTG] base_cancel_confirm: Migration to 15.0
c42ba01
@TheerayutEncoder
[UPD] Update base_cancel_confirm.pot
6c5a92b
@OCA-git-bot @TheerayutEncoder
[UPD] README.rst
e2ced05
@weblate @TheerayutEncoder
Update translation files
191965a 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: server-ux-15.0/server-ux-15.0-base_cancel_confirm
Translate-URL: https://translation.odoo-community.org/projects/server-ux-15-0/server-ux-15-0-base_cancel_confirm/
@aliciagaarzo @TheerayutEncoder
[MIG] base_cancel_confirm: Migration to 16.0
e4eb7b0
@TheerayutEncoder
[UPD] Update base_cancel_confirm.pot
3793936
@OCA-git-bot @TheerayutEncoder
[UPD] README.rst
82299d4
@weblate @TheerayutEncoder
Update translation files
d243f5a 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: server-ux-16.0/server-ux-16.0-base_cancel_confirm
Translate-URL: https://translation.odoo-community.org/projects/server-ux-16-0/server-ux-16-0-base_cancel_confirm/
@OCA-git-bot @TheerayutEncoder
[UPD] README.rst
01486fc
@Ivorra78 @TheerayutEncoder
Added translation using Weblate (Spanish)
e66512b
@Ivorra78 @TheerayutEncoder
Translated using Weblate (Spanish)
63ce462 
Currently translated at 100.0% (22 of 22 strings)

Translation: server-ux-16.0/server-ux-16.0-base_cancel_confirm
Translate-URL: https://translation.odoo-community.org/projects/server-ux-16-0/server-ux-16-0-base_cancel_confirm/es/
@mymage @TheerayutEncoder
Added translation using Weblate (Italian)
d210261
@mymage @TheerayutEncoder
Translated using Weblate (Italian)
0d51af9 
Currently translated at 100.0% (22 of 22 strings)

Translation: server-ux-16.0/server-ux-16.0-base_cancel_confirm
Translate-URL: https://translation.odoo-community.org/projects/server-ux-16-0/server-ux-16-0-base_cancel_confirm/it/
@JordiMForgeFlow @TheerayutEncoder
[FIX] base_cancel_confirm: correct get_view method
872ce4e
@OCA-git-bot @TheerayutEncoder
[BOT] post-merge updates
ba3ffd1
@TheerayutEncoder
[IMP] base_cancel_confirm: black, isort, prettier
ad68a2f
@TheerayutEncoder TheerayutEncoder mentioned this pull request Nov 21, 2024
Merged
@natuan9
Copy link
Contributor

natuan9 commented Dec 27, 2024 •
edited
Loading

Hi @TheerayutEncoder , It seem there might be some mistake, as I don't see commit:
[MIG] base_cancel_confirm: Migration to 18.0
Are you still working on this PR?

@TheerayutEncoder
Copy link
Member Author

Dear @natuan9
Oh
This is my mistake I committed wrong commit message.

I will fix this.

Thanks for review.

@natuan9
Copy link
Contributor

natuan9 commented Jan 7, 2025 •
edited
Loading

Hi @TheerayutEncoder , I created this PR to fix the KeyError 'arch' in the unit test.

@AlexPForgeFlow
Copy link
Contributor

@TheerayutEncoder could you fix commit message and include @natuan9 fix? Code LGTM!

@TheerayutEncoder TheerayutEncoder force-pushed the 18.0-mig-base_cancel_confirm branch from 358e929 to ccf43f0 Compare February 18, 2025 09:48
@TheerayutEncoder TheerayutEncoder force-pushed the 18.0-mig-base_cancel_confirm branch from 1ed2266 to 1a24a52 Compare February 18, 2025 10:17
@TheerayutEncoder
Copy link
Member Author

Dear @natuan9 @AlexPForgeFlow

Fixed commit message

@JordiBForgeFlow
Copy link
Member

@LoisRForgeFlow can you merge?

@LoisRForgeFlow
Copy link
Contributor

@LoisRForgeFlow can you merge?

The PR has zero approvals, we need at least 2.

JordiMForgeFlow
JordiMForgeFlow approved these changes Feb 24, 2025
View reviewed changes
Copy link
Contributor

@JordiMForgeFlow JordiMForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code + functional review

AlexPForgeFlow
AlexPForgeFlow approved these changes Feb 24, 2025
View reviewed changes
Copy link
Contributor

@AlexPForgeFlow AlexPForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@LoisRForgeFlow
Copy link
Contributor

/ocabot migration base_cancel_confirm

/ocabot merge nobump

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone Feb 24, 2025
@OCA-git-bot OCA-git-bot mentioned this pull request Feb 24, 2025
Open
26 tasks
@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 18.0-ocabot-merge-pr-972-by-LoisRForgeFlow-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 88c9caa into OCA:18.0 Feb 24, 2025
5 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 6c70f99. Thanks a lot for contributing to OCA. ❤️

@JordiMForgeFlow JordiMForgeFlow mentioned this pull request Mar 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JordiMForgeFlow JordiMForgeFlow JordiMForgeFlow approved these changes

@AlexPForgeFlow AlexPForgeFlow AlexPForgeFlow approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
18.0
Development

Successfully merging this pull request may close these issues.