Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG] base_search_mail_content #1154

Closed

Conversation

Highcooley
Copy link

No description provided.

serpentcs-dev1 and others added 26 commits June 5, 2023 15:31
Introduce search of html fields
Create indexes
Update Readme
On views with a searchpanel, xpath `//field[last()]` may select an element inside
the search panel, provoking the error "Only types ['many2one'] are supported for
category (found type text)".

This fix uses an stricter xpath for avoiding this situation.

TT25796
Avoid CacheMiss errors setting a value on message_content field.
Currently translated at 100.0% (9 of 9 strings)

Translation: social-15.0/social-15.0-base_search_mail_content
Translate-URL: https://translation.odoo-community.org/projects/social-15-0/social-15-0-base_search_mail_content/ca/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: social-15.0/social-15.0-base_search_mail_content
Translate-URL: https://translation.odoo-community.org/projects/social-15-0/social-15-0-base_search_mail_content/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: social-15.0/social-15.0-base_search_mail_content
Translate-URL: https://translation.odoo-community.org/projects/social-15-0/social-15-0-base_search_mail_content/
@Highcooley Highcooley force-pushed the 16.0-mig-base_search_mail_content branch from a4b8d9f to c2269fd Compare June 5, 2023 15:52
@Highcooley Highcooley marked this pull request as ready for review June 5, 2023 15:57
Copy link

@luis-ron luis-ron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review, LGTM

@rafaelbn
Copy link
Member

/ocabot migration base_search_mail_content

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Jun 13, 2023
@OCA-git-bot OCA-git-bot mentioned this pull request Jun 13, 2023
38 tasks
@OCA-git-bot
Copy link
Contributor

The migration issue (#974) has been updated to reference the current pull request.
however, a previous pull request was referenced : #1164.
Perhaps you should check that there is no duplicate work.
CC : @anddago78

Copy link
Contributor

@Shide Shide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not able to search on message_content field (the one that adds this module) on any view.

The option to search should appear on the bottom of the search filters.

mc

Please test the migrated module by yourself before making it ready to review or mark it like draft.

@yajo
Copy link
Member

yajo commented Jun 14, 2023

#1164 works, this one doesn't. Let's continue there. Thanks everyone!

@yajo yajo closed this Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.