[MIG] stock_orderpoint_route: Migration to 18.0 #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve code after reviews * performance (less queries executed) * disable tracking in tests (faster) * use with_user instead of sudo * the double for loop in _compute_route_ids actually generates one more query as the simple one in this commit (thanks to the cache) * extract a method * the parent locations can be found using 'parent_of' which will use the parent_path under the hood (example: 1/7/8 will return locations 1, 7, 8)
This is to avoid issue below for any module that inherits tree view of
the model `stock.warehouse.orderpoint`. Example: `stock_orderpoint_manual_procurement`
Field route_ids used in field route_id default domain
([('id', 'in', route_ids)]) must be present in view but is missing.
Complete the fix done in 06dfeedc66
grindtildeath
force-pushed
the
18.0-mig-stock_orderpoint_route
branch
from
88b35ce to
ddd4c89
Compare
ivantodorovich
approved these changes
Feb 6, 2025
|
This one will need fixing because IMO the condition to filter routes in
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.