-
-
Notifications
You must be signed in to change notification settings - Fork 672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][ADD] stock_picking_batch_print_invoices #1485
[16.0][ADD] stock_picking_batch_print_invoices #1485
Conversation
bdd1923
to
f2fa82e
Compare
stock_picking_batch_print_invoices/models/stock_picking_type.py
Outdated
Show resolved
Hide resolved
stock_picking_batch_print_invoices/models/stock_picking_type.py
Outdated
Show resolved
Hide resolved
72c2131
to
f0fde17
Compare
4dfac8e
to
c128f35
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @EmilioPascual
Nice job! But I think there is a behavior that is not correct. If there are several orders in an invoice that contain several delivery notes, the invoice is printed every time a delivery note is printed. And in the end, the invoice is printed as many times as there are delivery notes.
For example, if invoice F001 contains delivery notes A001, A002, and A003, it will be printed as follows:
A001
F001
A002
F001
A003
F001
https://www.loom.com/share/bd321c1fd6334327b3d660381b5e98ee?sid=46a70a72-fdc0-40c3-8500-346ad9366c4e
Can you check it please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A lot of suggestions but none of them is blocking. Good job!
stock_picking_batch_print_invoices/models/stock_picking_type.py
Outdated
Show resolved
Hide resolved
stock_picking_batch_print_invoices/models/stock_picking_type.py
Outdated
Show resolved
Hide resolved
stock_picking_batch_print_invoices/models/stock_picking_type.py
Outdated
Show resolved
Hide resolved
stock_picking_batch_print_invoices/models/stock_picking_type.py
Outdated
Show resolved
Hide resolved
stock_picking_batch_print_invoices/tests/test_batch_print_invoices.py
Outdated
Show resolved
Hide resolved
stock_picking_batch_print_invoices/tests/test_batch_print_invoices.py
Outdated
Show resolved
Hide resolved
be335ff
to
0bd4b8a
Compare
Fix for stock_picking_group_by_partner_by_carrier to pass the tests: Sometimes method get_remaining_to_deliver is not defined, so it is checkedt first. |
@moduon MT-4407 Co-authored-by: Jairo Llopis <[email protected]>
…heck get_remaining_to_deliver In some times, method get_remaining_to_deliver is not defined in template. @moduon MT-4407
0bd4b8a
to
87d2bda
Compare
Improvement to print only once the invoice if several pickings are invoiced in single invoice. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just found one typo, but the rest looks very good.
@@ -0,0 +1 @@ | |||
This module extends the functionality of stock batch pickings and to allows you to print multiple invoices from batches. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This module extends the functionality of stock batch pickings and to allows you to print multiple invoices from batches. | |
This module extends the functionality of stock batch pickings to let you print multiple invoices from batches. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ocabot merge patch
On my way to merge this fine PR! |
Congratulations, your PR was merged at d3e71bf. Thanks a lot for contributing to OCA. ❤️ |
This module was developed to be able to print invoices from batches and to be able print multiple copies.
It will be useful for you if you want to print all invoices included in a batch together.
It's neccesary #1481 to merge.
@rafaelbn @Gelojr @Shide @yajo @fcvalgar please review, if you want 😉
@moduon MT-4407