Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][ADD] stock_picking_batch_print_invoices #1485

Merged
merged 3 commits into from
Jan 29, 2024

Conversation

EmilioPascual
Copy link
Contributor

@EmilioPascual EmilioPascual commented Jan 19, 2024

This module was developed to be able to print invoices from batches and to be able print multiple copies.

It will be useful for you if you want to print all invoices included in a batch together.

It's neccesary #1481 to merge.

@rafaelbn @Gelojr @Shide @yajo @fcvalgar please review, if you want 😉

@moduon MT-4407

@EmilioPascual EmilioPascual changed the title [16.0][ADD stock picking batch print invoices [16.0][ADD stock_picking_batch_print_invoices Jan 19, 2024
@EmilioPascual EmilioPascual force-pushed the 16.0-stock_picking_batch_print_invoices branch from bdd1923 to f2fa82e Compare January 19, 2024 09:40
@EmilioPascual EmilioPascual changed the title [16.0][ADD stock_picking_batch_print_invoices [16.0][ADD] stock_picking_batch_print_invoices Jan 19, 2024
@EmilioPascual EmilioPascual force-pushed the 16.0-stock_picking_batch_print_invoices branch 2 times, most recently from 72c2131 to f0fde17 Compare January 19, 2024 12:15
@rafaelbn rafaelbn added this to the 16.0 milestone Jan 22, 2024
@EmilioPascual EmilioPascual force-pushed the 16.0-stock_picking_batch_print_invoices branch 2 times, most recently from 4dfac8e to c128f35 Compare January 24, 2024 18:12
Copy link
Contributor

@Gelojr Gelojr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @EmilioPascual
Nice job! But I think there is a behavior that is not correct. If there are several orders in an invoice that contain several delivery notes, the invoice is printed every time a delivery note is printed. And in the end, the invoice is printed as many times as there are delivery notes.
For example, if invoice F001 contains delivery notes A001, A002, and A003, it will be printed as follows:
A001
F001
A002
F001
A003
F001
https://www.loom.com/share/bd321c1fd6334327b3d660381b5e98ee?sid=46a70a72-fdc0-40c3-8500-346ad9366c4e
Can you check it please?

Copy link
Member

@yajo yajo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot of suggestions but none of them is blocking. Good job!

@EmilioPascual EmilioPascual force-pushed the 16.0-stock_picking_batch_print_invoices branch 2 times, most recently from be335ff to 0bd4b8a Compare January 26, 2024 10:21
@EmilioPascual
Copy link
Contributor Author

Fix for stock_picking_group_by_partner_by_carrier to pass the tests: Sometimes method get_remaining_to_deliver is not defined, so it is checkedt first.

EmilioPascual and others added 3 commits January 26, 2024 14:03
…heck get_remaining_to_deliver

In some times, method get_remaining_to_deliver is not defined in template.

@moduon MT-4407
@EmilioPascual EmilioPascual force-pushed the 16.0-stock_picking_batch_print_invoices branch from 0bd4b8a to 87d2bda Compare January 26, 2024 13:13
@EmilioPascual
Copy link
Contributor Author

Improvement to print only once the invoice if several pickings are invoiced in single invoice.

Copy link
Member

@yajo yajo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just found one typo, but the rest looks very good.

@@ -0,0 +1 @@
This module extends the functionality of stock batch pickings and to allows you to print multiple invoices from batches.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This module extends the functionality of stock batch pickings and to allows you to print multiple invoices from batches.
This module extends the functionality of stock batch pickings to let you print multiple invoices from batches.

Copy link
Member

@rafaelbn rafaelbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-1485-by-rafaelbn-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 9e0b884 into OCA:16.0 Jan 29, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at d3e71bf. Thanks a lot for contributing to OCA. ❤️

@yajo yajo deleted the 16.0-stock_picking_batch_print_invoices branch January 29, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants