Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][FIX] stock_receipt_lot_info: hook merged into odoo #1492

Merged
merged 3 commits into from
Feb 5, 2024

Conversation

LoisRForgeFlow
Copy link
Contributor

@LoisRForgeFlow LoisRForgeFlow commented Jan 25, 2024

A hook was introduced in odoo (15.0 and 16.0), but with a different name _get_value_production_lot.

Tests in version 16 were incorrect... not testing what was needed, in this commit this is fixed and they test the functionality properly.

Forwardport of last 3 commits in #1363

A hook was introduced in odoo (15.0 and 16.0), but with a different
name `_get_value_production_lot`.

Tests in version 16 were incorrect... not testing what was needed,
in this commit this is fixed and they test the functionality
properly.
@LoisRForgeFlow LoisRForgeFlow force-pushed the 16.0-fix-stock_receipt_lot_info branch from 9a97625 to d7a05fb Compare January 25, 2024 22:43
Odoo introduced a new field in sml `expiration_date` that does almost the
same as `lot_expiration_date`.
Make it clear the behavior that can be obtained with this module
and how it differs from standard.
Copy link

@JoanSForgeFlow JoanSForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected!

@LoisRForgeFlow
Copy link
Contributor Author

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-1492-by-LoisRForgeFlow-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 19cd466 into OCA:16.0 Feb 5, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at dc5241b. Thanks a lot for contributing to OCA. ❤️

@LoisRForgeFlow LoisRForgeFlow deleted the 16.0-fix-stock_receipt_lot_info branch February 5, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants