-
-
Notifications
You must be signed in to change notification settings - Fork 671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][ADD] stock_picking_partner_note #1496
[16.0][ADD] stock_picking_partner_note #1496
Conversation
6c9a45d
to
9931852
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG. Just a few small remarks
<field name="name" /> | ||
<field name="note_type_id" /> | ||
<field name="active" /> | ||
</group> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be useful to see the list of partners having this note
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, but use a smart btn rather than a direct listing of m2m
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nooooo 😨
Keop it simple, just list them, there is nothing on that view. Easier to visualize and change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A smart button wouldn't work because stock_picking_note_ids
because is a M2M and not O2M.
With a button you would be able to create a new note BUT detached from the partner.
I keep the simple version showing the notes directly in the form
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A smart button wouldn't work because stock_picking_note_ids because is a M2M and not O2M.
With a button you would be able to create a new note BUT detached from the partner.
This is wrong. You will have an action to handle the btn and you can search for the records you need. No matter if o2m or m2m.
Regarding creation, that's wrong too: you simply have to set the default partner in the context.
I keep the simple version showing the notes directly in the form
Ok, but that's about time and not about possibilities 😉
<field name="name" /> | ||
<field name="note_type_id" /> | ||
<field name="active" /> | ||
</group> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, but use a smart btn rather than a direct listing of m2m
a380262
to
8a2e5fe
Compare
<field name="name" /> | ||
<field name="note_type_id" /> | ||
<field name="active" /> | ||
</group> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A smart button wouldn't work because stock_picking_note_ids because is a M2M and not O2M.
With a button you would be able to create a new note BUT detached from the partner.
This is wrong. You will have an action to handle the btn and you can search for the records you need. No matter if o2m or m2m.
Regarding creation, that's wrong too: you simply have to set the default partner in the context.
I keep the simple version showing the notes directly in the form
Ok, but that's about time and not about possibilities 😉
stock_picking_partner_note/views/stock_picking_partner_note_menus.xml
Outdated
Show resolved
Hide resolved
stock_picking_partner_note/views/stock_picking_partner_note_menus.xml
Outdated
Show resolved
Hide resolved
8a2e5fe
to
1495d90
Compare
1495d90
to
355a504
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review. IMHO, quite tough to manage for picking users if several per picking types. Fortunately, it's not one per customer 😅
Note: Purpose is to remove from shopfloor the shopfloor.packing.info and replace it by this more generic module. |
This PR has the |
/ocabot merge nobump |
This PR looks fantastic, let's merge it! |
Congratulations, your PR was merged at 57860b2. Thanks a lot for contributing to OCA. ❤️ |
Allow to record a message for the person in charge of order preparation at the level of the customer,
then have it as a note on the picking transfer.
Example: Max pallet height 1m20
Note: This will allow to remove from shopfloor the shopfloor.packing.info and replace it by this more generic module.