[16.0][IMP] stock_picking_group_by_partner_by_carrier: Control the original_group_id propagation. #1498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rousseldenis
reviewed
Feb 7, 2024
lmignon
force-pushed
the
16.0-stock_picking_group_by_partner_by_carrier-fix_orignal_group_id_propagation-lmi
branch
2 times, most recently
from
87013af to
bce2fbe
Compare
jbaudoux
requested changes
Feb 20, 2024
| @@ -267,6 +277,73 @@ def test_delivery_multi_step_group_pick(self): | |||
| self.assertEqual(len(picks), 1) | |||
| self.assertFalse(so1.picking_ids - so2.picking_ids) | |||
|
|
|||
| def test_delivery_multi_step_group_out_pick_op_merged(self): | |||
There was a problem hiding this comment.
This should not be possible
There was a problem hiding this comment.
I would drop this test that does not make sense as you should not be able to enable grouping on non outgoing picking type
lmignon
force-pushed
the
16.0-stock_picking_group_by_partner_by_carrier-fix_orignal_group_id_propagation-lmi
branch
from
9019d32 to
8b93125
Compare
|
Back to draft. Compatibility issue with the stock_available_to_promise_release. |
lmignon
force-pushed
the
16.0-stock_picking_group_by_partner_by_carrier-fix_orignal_group_id_propagation-lmi
branch
from
eb843bb to
d0b3f42
Compare
lmignon
force-pushed
the
16.0-stock_picking_group_by_partner_by_carrier-fix_orignal_group_id_propagation-lmi
branch
from
fa55d62 to
1cd4911
Compare
|
@lmignon Can you drop changes to generated files? |
…ed group When merging an outgoing picking, update only the current moves with the new procurement group. This is required to ensure that an update of the quantity on a SO will be properly applied to all the picking chain through the run of stock rules.
… propagation configurable on stock rule. In a multi steps delivery process, when you allow to group the moves linked to the same carrier and partner into the same shipping, it's important to be able to merge internal moves that could be pulled. This merge is only possible if the original_group_id is not propagated to the pulled moves. We add an option to disable the propagation on the stock.rule.
…p swap When the grouping functionality is enabled. A new procurement group is created the first time a pick out is created as merged. Every time moves from a new group are added into the picking, the merged procurement is updated to link the new group. In this way, the group is never updated after its original creation
When a backorder is created from a merged picking, a new procurement group must be created to ensure that only original sale orders and procurement group from the remaining moves are linked to the backorder.
lmignon
force-pushed
the
16.0-stock_picking_group_by_partner_by_carrier-fix_orignal_group_id_propagation-lmi
branch
from
afddd2b to
6365ef5
Compare
|
@jbaudoux tests removed and rebase done |
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.