[18.0][MIG] stock_picking_purchase_order_link: Migration to 18.0 #1809
Conversation
As odoo mentioned this changes here: odoo/odoo#53335
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: stock-logistics-workflow-16.0/stock-logistics-workflow-16.0-stock_picking_purchase_order_link Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-16-0/stock-logistics-workflow-16-0-stock_picking_purchase_order_link/
Currently translated at 100.0% (2 of 2 strings) Translation: stock-logistics-workflow-16.0/stock-logistics-workflow-16.0-stock_picking_purchase_order_link Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-16-0/stock-logistics-workflow-16-0-stock_picking_purchase_order_link/pt_BR/
Currently translated at 100.0% (2 of 2 strings) Translation: stock-logistics-workflow-16.0/stock-logistics-workflow-16.0-stock_picking_purchase_order_link Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-16-0/stock-logistics-workflow-16-0-stock_picking_purchase_order_link/it/
Currently translated at 100.0% (2 of 2 strings) Translation: stock-logistics-workflow-16.0/stock-logistics-workflow-16.0-stock_picking_purchase_order_link Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-16-0/stock-logistics-workflow-16-0-stock_picking_purchase_order_link/fr/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: stock-logistics-workflow-17.0/stock-logistics-workflow-17.0-stock_picking_purchase_order_link Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-17-0/stock-logistics-workflow-17-0-stock_picking_purchase_order_link/
| self.product = self.product_product_obj.create( | ||
| { | ||
| "name": "product_template_obj - Test", | ||
| # "type": "product", |
There was a problem hiding this comment.
The equivalent is:
| # "type": "product", | |
| "type": "consu", | |
| "is_storable": True, |
There was a problem hiding this comment.
@celm1990 , Thanks for the suggestions! Please review.
HeliconiaSolutions
force-pushed
the
18.0-mig-stock_picking_purchase_order_link
branch
from
518df7d to
f1828e9
Compare
| - Adria Gil Sorribes \<<[email protected]>\> | ||
| - Jaume Planas \<<[email protected]>\> | ||
| - Joan Mateu Jordi \<<[email protected]>\> | ||
| - `Heliconia Solutions Pvt. Ltd. <https://www.heliconia.io>`_ |
There was a problem hiding this comment.
@HeliconiaSolutions @StefanRijnhart As already said elsewhere, in CONTRIBUTORS.rst should appear individual contributors (even if company can be set as title).
There was a problem hiding this comment.
@rousseldenis for my information, I remember this being debated but is there a guideline published somewhere or a statement from the board?
There was a problem hiding this comment.
This is a common guideline in opensource projects. Contributors are individuals. There is author part for companies.
There was a problem hiding this comment.
a company by itself does not write code nor documentation 😃
There was a problem hiding this comment.
@rousseldenis So if the company is removed from the list of contributors it's ok for you?
stock_picking_purchase_order_link/tests/test_stock_picking_purchase_order_link.py
Outdated
Show resolved
Hide resolved
HeliconiaSolutions
force-pushed
the
18.0-mig-stock_picking_purchase_order_link
branch
from
f1828e9 to
960798f
Compare
HeliconiaSolutions
force-pushed
the
18.0-mig-stock_picking_purchase_order_link
branch
from
960798f to
fc5ae99
Compare
HeliconiaSolutions
force-pushed
the
18.0-mig-stock_picking_purchase_order_link
branch
from
fc5ae99 to
b6f1e0f
Compare
There was a problem hiding this comment.
I prefer the smart button, but aligned with Odoo's style. Let's go, LGTM.
Note: I think the same change should be applied to stock_picking_sale_order_link.
@pedrobaeza could you please take a look?
|
This PR has the |
|
/ocabot migration stock_picking_purchase_order_link |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at af2f19d. Thanks a lot for contributing to OCA. ❤️ |
No description provided.