Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MIG] stock_split_picking: Migration to version 18.0 #1857

Merged
merged 65 commits into from
Feb 10, 2025
Merged

[MIG] stock_split_picking: Migration to version 18.0 #1857

merged 65 commits into from
Feb 10, 2025

Conversation

gbrito
Copy link

@gbrito gbrito commented Jan 29, 2025

No description provided.

guewen and others added 30 commits January 29, 2025 15:30
@guewen @gbrito
[MRG] from master branch
b1c1afb 
(/home/jgrandguillaume/c2c/ProjetsEC/IFRC/Code/openerp_70_ifrc_core_dev/parts/generic-addons rev 29.1.1)
@guewen @gbrito
[FIX] prevents a KeyError is the context is None
9a7446d 
(/home/jgrandguillaume/c2c/ProjetsEC/IFRC/Code/openerp_70_ifrc_core_dev/parts/generic-addons rev 29.1.14)
@nbessi @gbrito
[FIX] donor in manifest
4111d98
@gurneyalex @gbrito
spellchecking
df1a895
@guewen @gbrito
Display the split button when the delivery order is in draft, waiting…
012d160 
… availability or ready to deliver
@gurneyalex @gbrito
mark unported module as uninstallable
d79adef
@yvaucher @gbrito
Reactivate stock_split_picking
1f39dfc
@yvaucher @gbrito
remove stock.picking.out
69bc4ac
@yvaucher @gbrito
Port to 8.0
6d5de17
@yvaucher @gbrito
Adapt tests
363bd97
@guewen @gbrito
Split procurements as well when a move is split
49612e6 
Both procurements will still be split to the sale order line.
If one of the picking is canceled, the whole sale order will be in
'shipping_exception'.
@guewen @gbrito
Allow to split a partially available picking
91993d1
@gurneyalex @gbrito
also show split button on incoming moves
75f396a
@gurneyalex @gbrito
handle reservations
d9425b6 
when splitting a move with reservations, they have to be recomputed.
code inspired from the implementation of stock_picking.rereserve_quants

split the tests in travis.yml because another module is changing the states we get
with only stock_split_picking installed

fix a bug in stock_ownership_by_move which would cause wrong pack operations to
be generated
@sbidoul @gbrito
[UPD] prefix versions with 8.0
27e517e
@pedrobaeza @gbrito
[MIG] Make modules uninstallable
05b3152
@pedrobaeza @gbrito
[MIG] Rename manifest files
b9ebd80
@oihane @gbrito
stock_split_picking: test error
f8aff21
@gbrito
stock_split_picking : open action instead of create wizard
9449507
@gbrito
allow split on internal picking]
0dc86c2
@cubells @gbrito
[MIG][10.0] stock_split_picking module
66a31e1
@cubells @gbrito
Improve coverage
a14bf6a
@jcoux @gbrito
[MIG][11.0] stock_split_picking
1367fc9
@sbidoul @gbrito
remove obsolete .pot files [ci skip]
67ac4c8
@gbrito
[MIG] stock_split_picking: Migration to 12.0
e945372
@gbrito
[MIG] stock_split_picking: Pre-commit to 13.0
5964cbf
@gbrito
[MIG] stock_split_picking: Migration to 13.0
80060b4
@hbrunn @gbrito
[ADD] stock_split_picking: Mode selection to split in different ways
3d15a4c
@RujiaL @gbrito
[IMP] stock_split_picking: black, isort, prettier
f2ad98b
@RujiaL @gbrito
[MIG] stock_split_picking: Migration to 14.0
b2ff09e
@gbrito gbrito force-pushed the 18.0-mig-stock_split_picking branch from fd5ca6d to 67d23df Compare January 31, 2025 07:45
@gbrito gbrito requested a review from bosd January 31, 2025 07:45
@gbrito
Copy link
Author

gbrito commented Jan 31, 2025

@bosd @StefanRijnhart Just pushed the requested changes

Really appreciate the interaction, do you guys mind if I tag you in future PR ?

StefanRijnhart
StefanRijnhart approved these changes Jan 31, 2025
View reviewed changes
Copy link
Member

@StefanRijnhart StefanRijnhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gbrito Sorry, not a big fan of tagging. It could get out of hand real quickly.

bosd
bosd approved these changes Jan 31, 2025
View reviewed changes
Copy link
Contributor

@bosd bosd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now 💯

jbaudoux
jbaudoux requested changes Jan 31, 2025
View reviewed changes
Copy link
Contributor

@jbaudoux jbaudoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the module migration

Can you include those fixes from v16:

And this PR #1788 is befing fixed and soon merged. You'll be able to integrate it as well

@StefanRijnhart
Copy link
Member

@jbaudoux About #1788: it's not being followed up by its author and there are changes requested. I don't think it qualifies for inclusion at this point.

@rousseldenis
Copy link
Contributor

@jbaudoux About #1788: it's not being followed up by its author and there are changes requested. I don't think it qualifies for inclusion at this point.

I check this now

@StefanRijnhart
Copy link
Member

OK, #1788 is also ready to be included.

JordiMForgeFlow and others added 4 commits February 10, 2025 14:17
@JordiMForgeFlow @gbrito
[FIX] stock_split_picking: pass backorder context when splitting
962da39 
If we do not pass the context, when splitting a picking for a
subcontracted product Odoo will consider that we are cancelling the
quantities that we split. Consequently, it will cancel the
subcontracting MO with the split quantity.
@AnizR @gbrito
[16.0][IMP] stock_split_picking: assign created moves only if reserva…
c259bc3 
…tion_method is 'at_confirm'
@rousseldenis @gbrito
[IMP] stock_split_picking: Use specific exceptions
47ed8eb
@rousseldenis @gbrito
[IMP] stock_split_picking: Add a common for tests
96cd6a9
@gbrito gbrito requested a review from jbaudoux February 10, 2025 13:43
@gbrito
Copy link
Author

gbrito commented Feb 10, 2025

@jbaudoux It should be okay now

jbaudoux
jbaudoux approved these changes Feb 10, 2025
View reviewed changes
Copy link
Contributor

@jbaudoux jbaudoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@jbaudoux
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 18.0-ocabot-merge-pr-1857-by-jbaudoux-bump-nobump, awaiting test results.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot OCA-git-bot merged commit 0fd637b into OCA:18.0 Feb 10, 2025
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at d85568c. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StefanRijnhart StefanRijnhart StefanRijnhart approved these changes

@jbaudoux jbaudoux jbaudoux approved these changes

@bosd bosd bosd approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
18.0
Development

Successfully merging this pull request may close these issues.