[MIG][16.0] stock_scrap_tier_validation #1867
Conversation
Currently translated at 100.0% (19 of 19 strings) Translation: stock-logistics-workflow-15.0/stock-logistics-workflow-15.0-stock_scrap_tier_validation Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-15-0/stock-logistics-workflow-15-0-stock_scrap_tier_validation/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: stock-logistics-workflow-15.0/stock-logistics-workflow-15.0-stock_scrap_tier_validation Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-15-0/stock-logistics-workflow-15-0-stock_scrap_tier_validation/
Currently translated at 100.0% (20 of 20 strings) Translation: stock-logistics-workflow-15.0/stock-logistics-workflow-15.0-stock_scrap_tier_validation Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-15-0/stock-logistics-workflow-15-0-stock_scrap_tier_validation/es/
Currently translated at 100.0% (20 of 20 strings) Translation: stock-logistics-workflow-15.0/stock-logistics-workflow-15.0-stock_scrap_tier_validation Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-15-0/stock-logistics-workflow-15-0-stock_scrap_tier_validation/it/
Currently translated at 100.0% (20 of 20 strings) Translation: stock-logistics-workflow-15.0/stock-logistics-workflow-15.0-stock_scrap_tier_validation Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-15-0/stock-logistics-workflow-15-0-stock_scrap_tier_validation/it/
Currently translated at 100.0% (20 of 20 strings) Translation: stock-logistics-workflow-15.0/stock-logistics-workflow-15.0-stock_scrap_tier_validation Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-15-0/stock-logistics-workflow-15-0-stock_scrap_tier_validation/it/
Currently translated at 100.0% (20 of 20 strings) Translation: stock-logistics-workflow-15.0/stock-logistics-workflow-15.0-stock_scrap_tier_validation Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-15-0/stock-logistics-workflow-15-0-stock_scrap_tier_validation/it/
StefanRijnhart
left a comment
StefanRijnhart
left a comment
There was a problem hiding this comment.
Here is one of the issues I solved in the earlier migration to 17.0: create a tier definition for stock.scrap. Go to a delivery transfer. Click the Scrap button. You get this error:
It is because the 'secondary' stock scrap popup view does not have the tier validation fields. This is solved in 9abffe9#diff-635ed623ad5aeed8a01ed21e71441fd81a5697bec804f2581bf843ecfea40d94. I really think you will want to take the rest of that commit as well, to prevent the other issue from showing up (the other issue being: the popup is only saved upon confirmation, but the confirmation is blocked because of the validation, resulting in a deadlock).
em230418
force-pushed
the
16.0-mig2-stock_scrap_tier_validation
branch
from
e0ecee7 to
20b4b25
Compare
…error when pressing scrap from picking Co-authored-by: Eugene Molotov <[email protected]>
em230418
force-pushed
the
16.0-mig2-stock_scrap_tier_validation
branch
from
20b4b25 to
61c2ddc
Compare
StefanRijnhart
left a comment
StefanRijnhart
left a comment
There was a problem hiding this comment.
Scrapping from stock picking now works, but you did not take the *_mrp glue module from my commit so predictably, scrapping from an mrp.production form still halts on the deadlock described above if validation is required.
|
Cherry-picked [ADD] stock_scrap_tier_validation_mrp from 17.0 |
|
/ocabot migration stock_scrap_tier_validation |
@em230418 That's quite a confession. I really wouldn't like running into issues testing a third time on this PR. Are you sure you don't want to have a go first? |
|
I have checked the "stock_scrap_tier_validation_mrp" and can confirm that it works without any issues. I created a scrap record in the manufacturing order, requested validation, and successfully validated it without any errors. The screenshots are attached.
|
| _tier_validation_manual_config = False | ||
|
|
||
| def _get_requested_notification_subtype(self): | ||
| return "stock_scrap_tier_validation.sale_order_tier_validation_requested" |
There was a problem hiding this comment.
Mail Subtypes seems wrong, could you cherry pick this commit?
b3d9677
There was a problem hiding this comment.
Please rereview #1894 and pick if you agree with the current version.
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
StefanRijnhart
added
no stale
10 participants
No description provided.