Skip to content

[18.0][MIG] stock_partner_delivery_window: Migration to 18.0 #1910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 39 commits into from
Apr 18, 2025
Merged

[18.0][MIG] stock_partner_delivery_window: Migration to 18.0 #1910

merged 39 commits into from
Apr 18, 2025

Conversation

ArnauCForgeFlow
Copy link
Contributor

Migration of stock_partner_delivery_window to version 18.0

Supersedes: #1783

grindtildeath and others added 30 commits February 4, 2025 16:22
@grindtildeath @thienvh332
Add stock_partner_delivery_window
6127347
@dzungtran89 @thienvh332
[IMP] stock_partner_delivery_window: black, isort, prettier
f695c17
@dzungtran89 @thienvh332
[MIG] stock_partner_delivery_window: Migration to 14.0
2581e71
@sebalix @thienvh332
s_p_delivery_window: time format improvements
58e61f0 
Two small improvements:

* add a hook to change the delivery time format
* no need to display seconds, hh:mm is enough
@simahawk @thienvh332
stock_partner_delivery_window: ease warning msg check/override
f6bfc67
@mmequignon @thienvh332
stock_partner_delivery_window: Cleanup
da20b3a
@mmequignon @thienvh332
s_p_delivery_window: Add working days as delivery schedule preference
3c05023
@grindtildeath @thienvh332
[FW][14.0] stock_partner_delivery_window: Fix default value on delive…
8ab14da 
…ry_time_preference

The default value introduced by workdays feature breaks the installation
of Demo databases as the change is not reflected in sale_partner_delivery_window.
@oca-travis @thienvh332
[UPD] Update stock_partner_delivery_window.pot
a37c232
@OCA-git-bot @thienvh332
[ADD] icon.png
c91bb2a
@OCA-git-bot @thienvh332
stock_partner_delivery_window 14.0.1.0.1
bc6ec40
@sebalix @thienvh332
[FIX] s_p_delivery_window: selection attribute will be ignored as the…
378d766 
… field is related
@OCA-git-bot @thienvh332
stock_partner_delivery_window 14.0.1.1.0
2014cee
@gurneyalex @thienvh332
[FIX] stock_partner_delivery_window version
04bbd3c 
version conflict prevents upload to pypi
@hailangvn @thienvh332
[IMP] stock_partner_delivery_window: copy time window ids of partner
bc926c9 
When copying partner, if the partner's delivery time preference is time
window, time window ids should be copied as well.
@OCA-git-bot @thienvh332
stock_partner_delivery_window 14.0.1.2.0
0b3546b
@rousseldenis @thienvh332
[14.0][FIX] Align development statuses
b1cd370
@OCA-git-bot @thienvh332
[UPD] README.rst
2f4bb59
@rousseldenis @thienvh332
[UPD] stock_partner_delivery_window: Upgrade to Beta
4f099ea
@OCA-git-bot @thienvh332
[UPD] README.rst
c22e838
@OCA-git-bot @thienvh332
stock_partner_delivery_window 14.0.1.2.1
3b0ee05
@mmequignon @thienvh332
s_p_delivery_window: Make delivery windows inclusive
aa727a3
@OCA-git-bot @thienvh332
stock_partner_delivery_window 14.0.1.2.2
d696078
@nguyenminhchien @thienvh332
[MIG] stock_partner_delivery_window: Migration to 16.0
6e53424
@thienvh332
[UPD] Update stock_partner_delivery_window.pot
c28b2a9
@OCA-git-bot @thienvh332
[BOT] post-merge updates
3317fc3
@Ivorra78 @thienvh332
Added translation using Weblate (Spanish)
97be7c1
@Ivorra78 @thienvh332
Translated using Weblate (Spanish)
e9b84ca 
Currently translated at 100.0% (27 of 27 strings)

Translation: stock-logistics-workflow-16.0/stock-logistics-workflow-16.0-stock_partner_delivery_window
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-16-0/stock-logistics-workflow-16-0-stock_partner_delivery_window/es/
@pedrobaeza @thienvh332
[FIX] *: Linter fixes
b252650
@OCA-git-bot @thienvh332
[BOT] post-merge updates
cb8ccc5
AaronHForgeFlow
AaronHForgeFlow approved these changes Apr 3, 2025
View reviewed changes
Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works ok, but I still see a "False" in the error message:

image

image

@ArnauCForgeFlow
Copy link
Contributor Author

Hey @AaronHForgeFlow that's because the partner doesn't have the timezone set, that's why its False.

@AaronHForgeFlow
Copy link
Contributor

Ok! so I assume the user must inform this value in order to use this feature.

@sebalix
Copy link
Contributor

sebalix commented Apr 7, 2025

/ocabot migration stock_partner_delivery_window

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone Apr 7, 2025
@OCA-git-bot
Copy link
Contributor

The migration issue (#1737) has not been updated to reference the current pull request because a previous pull request (#1783) is not closed.
Perhaps you should check that there is no duplicate work.
CC @thienvh332

@sebalix sebalix mentioned this pull request Apr 7, 2025
Open
69 tasks
sebalix
sebalix reviewed Apr 8, 2025
View reviewed changes
sebalix
sebalix reviewed Apr 9, 2025
View reviewed changes
sebalix
sebalix reviewed Apr 9, 2025
View reviewed changes
@ArnauCForgeFlow ArnauCForgeFlow force-pushed the 18.0-mig-stock_partner_delivery_window branch from d619a11 to 255182f Compare April 10, 2025 08:27
@ArnauCForgeFlow
Copy link
Contributor Author

ArnauCForgeFlow commented Apr 10, 2025 •
edited
Loading

@sebalix Thanks for your comments! could you review it again?

sebalix
sebalix reviewed Apr 11, 2025
View reviewed changes
@ArnauCForgeFlow ArnauCForgeFlow force-pushed the 18.0-mig-stock_partner_delivery_window branch from 255182f to bb1b209 Compare April 11, 2025 14:54
@ArnauCForgeFlow
Copy link
Contributor Author

@sebalix Done! let me know if it is okay now.

Thanks!

@ArnauCForgeFlow ArnauCForgeFlow force-pushed the 18.0-mig-stock_partner_delivery_window branch from bb1b209 to ed4e447 Compare April 11, 2025 15:01
sebalix
sebalix reviewed Apr 15, 2025
View reviewed changes
@ArnauCForgeFlow ArnauCForgeFlow force-pushed the 18.0-mig-stock_partner_delivery_window branch from ed4e447 to ecadda2 Compare April 16, 2025 15:02
@sebalix
Copy link
Contributor

sebalix commented Apr 18, 2025

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 18.0-ocabot-merge-pr-1910-by-sebalix-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 440973b into OCA:18.0 Apr 18, 2025
6 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at f4fcde9. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebalix sebalix sebalix approved these changes

@AaronHForgeFlow AaronHForgeFlow AaronHForgeFlow approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 migration
Projects
None yet
Milestone
18.0
Development

Successfully merging this pull request may close these issues.