[17.0] [MIG] stock_picking_tier_validation: migration to v17 #1962
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rrebollo
force-pushed
the
17.0-mig-stock_picking_tier_validation
branch
3 times, most recently
from
e12f370 to
fa1979b
Compare
rrebollo
force-pushed
the
17.0-mig-stock_picking_tier_validation
branch
from
fa1979b to
b001590
Compare
|
ping @Christian-RB |
|
This PR has the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Standard migration from v14 to v17.
Key Points
The tests were failing due to certain methods in
base_tier_validationusing raw SQL queries. Since test transactions are not committed to the database, these raw queries were unable to retrieve the expected data, resulting in failed assertions.To resolve this, we refactored the tests by moving the scenario setup logic to the
setUpClassmethod, which runs in the main transaction and ensures the data is "committed". The actual test methods now run in sub-transactions, allowing raw SQL queries to access the prepared data correctly.With this approach, the tests now pass as expected.
#1421
@BinhexTeam
Lots of credit to #1875