[18.0][MIG] stock_checkout_sync #1979

sebalix · 2025-06-05T15:42:08Z

Migrated from OCA/wms#14.0.

Issue about updating locations directly on moves and on backorders

Starting from Odoo 18.0, source/dest locations on moves are coming directly from the related stock.picking. Fields are stored=True / readonly=False, but when Odoo is putting a backorder move in its own transfer, this is resetting the source/dest locations that were set on it (see https://github.com/odoo/odoo/blob/18.0/addons/stock/models/stock_picking.py#L1585).

Should we split these moves in their own picking (with the expected dest location) when syncing them?

M1 (assigned) A -> B
M2 (assigned) A -> B

Sync both moves to reach C:

M1 (assigned) A -> C
M2 (assigned) A -> C

Validate M1, so we get M2 in its own backorder transfer:

M1 (done)     A -> C
M2 (assigned) A -> B    # /!\ Reset to 'stock.picking' dest location

An idea would be to set the synced dest location not only on the moves themselves, but on their stock.picking, so all moves in this transfert will be synced to reach C.

The issue by doing that is it doesn't fulfill an existing use-case, which is having one of the moves having a different stock.picking as a destination than the others, so not impacted by the sync of other moves:

M1 (assigned) A -> B from PICK1, targetting M3 part of PACK1
M2 (assigned) A -> B from PICK1, targetting M4 part of PACK2

Sync M1 to C:

M1 (assigned) A -> C from PICK1, targetting M3 part of PACK1
M2 (assigned) A -> B from PICK1, targetting M4 part of PACK2

In 14.0 we were able to get different moves (M1 + M2) part of the same transfert (PICK1) but having different dest locations (as soon as they respect the parent location defined by the stock.picking).
Keeping this logic in 18.0 seems dangerous:

technically that could still work, excepted when dealing with backorders as seen above (dest location is reset)
updating directly location fields on the move seems fragile in 18.0, the system is thought to update locations on the related stock.picking, not directly on moves independently (I see it that way, could be wrong).

EDIT: after discussion with @jbaudoux , the use-case having moves within the same PICK transfer targetting different PACK transfers should not happen / be supported => removing/adapting tests accordingly + sync the location both on stock.picking + moves, no discrepancy allowed.

Add an assistant to select the same destination location for all the moves that will reach the same transfer. Generally used on packing locations.

m is supposed to be part of moves_to_update.move_dest_ids, and moves_to_update is already a subset of self so it's always True

* union ids in a set instead of browse for performance in case of many moves * improve summary description in glue module * remove redundant code in test * split test common case in "common.py": we shouldn't import a test file from another module

Currently translated at 100.0% (35 of 35 strings) Translation: wms-13.0/wms-13.0-stock_checkout_sync Translate-URL: https://translation.odoo-community.org/projects/wms-13-0/wms-13-0-stock_checkout_sync/es_AR/

Currently translated at 100.0% (35 of 35 strings) Translation: wms-14.0/wms-14.0-stock_checkout_sync Translate-URL: https://translation.odoo-community.org/projects/wms-14-0/wms-14-0-stock_checkout_sync/it/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: wms-14.0/wms-14.0-stock_checkout_sync Translate-URL: https://translation.odoo-community.org/projects/wms-14-0/wms-14-0-stock_checkout_sync/

Currently translated at 100.0% (35 of 35 strings) Translation: wms-14.0/wms-14.0-stock_checkout_sync Translate-URL: https://translation.odoo-community.org/projects/wms-14-0/wms-14-0-stock_checkout_sync/it/

twalter-c2c

Technically, LGTM.

jbaudoux · 2025-06-10T13:31:09Z

stock_checkout_sync/wizards/stock_move_checkout_sync.py

+        comodel_name="stock.picking",
+        relation="stock_move_checkout_sync_stock_picking_done_dest_rel",
+    )
+    show_skip_button = fields.Boolean(default=False)


i guess this should be enough

Suggested change

show_skip_button = fields.Boolean(default=False)

show_skip_button = fields.Boolean()

OCA-git-bot · 2025-06-10T15:51:14Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

marcelsavegnago

LGTM

jbaudoux

As discussed, I'm not sure it's still right to change the destination of the moves and not of the picking as now the destination of the move is computed.

jbaudoux

Because it doesn't work anymore on backorder due to the compute. There should be a failing test.

jbaudoux · 2025-06-16T10:21:57Z

stock_checkout_sync/models/stock_move.py

        # Sync the source of the destination move too, if it's still waiting.
-        moves_to_update.move_dest_ids.filtered(
+        moves_dest = moves_to_update.move_dest_ids.filtered(
+            # FIXME add partially_available?


yes, and confirmed as well

jbaudoux

@sebalix you squash the fixups?

OCA-git-bot · 2025-07-01T13:39:07Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

guewen and others added 20 commits June 5, 2025 17:16

Add stock_checkout_sync

515d07e

Add an assistant to select the same destination location for all the moves that will reach the same transfer. Generally used on packing locations.

Add a test ensuring new move lines have correct destination

73c4739

Remove useless check (code review)

e5fbfe8

m is supposed to be part of moves_to_update.move_dest_ids, and moves_to_update is already a subset of self so it's always True

Synchronize destination location on package level

03947e2

Improvements after code review

98dd179

* union ids in a set instead of browse for performance in case of many moves * improve summary description in glue module * remove redundant code in test * split test common case in "common.py": we shouldn't import a test file from another module

Added translation using Weblate (Spanish (Argentina))

7744e1d

Translated using Weblate (Spanish (Argentina))

d6560a1

Currently translated at 100.0% (35 of 35 strings) Translation: wms-13.0/wms-13.0-stock_checkout_sync Translate-URL: https://translation.odoo-community.org/projects/wms-13-0/wms-13-0-stock_checkout_sync/es_AR/

[MIG] stock_checkout_sync: Migration to 14.0

275b9a4

[UPD] Update stock_checkout_sync.pot

d3820cb

[UPD] README.rst

febb460

stock_checkout_sync: dev status -> Beta

f043c67

[UPD] README.rst

a934605

stock_checkout_sync 14.0.1.1.0

e5474b4

[UPD] README.rst

1e9fc3c

Added translation using Weblate (Italian)

b5eaeb0

Translated using Weblate (Italian)

b785787

Currently translated at 100.0% (35 of 35 strings) Translation: wms-14.0/wms-14.0-stock_checkout_sync Translate-URL: https://translation.odoo-community.org/projects/wms-14-0/wms-14-0-stock_checkout_sync/it/

Update translation files

7ecefc1

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: wms-14.0/wms-14.0-stock_checkout_sync Translate-URL: https://translation.odoo-community.org/projects/wms-14-0/wms-14-0-stock_checkout_sync/

Translated using Weblate (Italian)

7b1f04c

Currently translated at 100.0% (35 of 35 strings) Translation: wms-14.0/wms-14.0-stock_checkout_sync Translate-URL: https://translation.odoo-community.org/projects/wms-14-0/wms-14-0-stock_checkout_sync/it/

Translated using Weblate (Italian)

3b2988b

Currently translated at 100.0% (35 of 35 strings) Translation: wms-14.0/wms-14.0-stock_checkout_sync Translate-URL: https://translation.odoo-community.org/projects/wms-14-0/wms-14-0-stock_checkout_sync/it/

[IMP] stock_checkout_sync: pre-commit auto fixes

ee379bf

sebalix added this to the 18.0 milestone Jun 5, 2025

sebalix added the migration label Jun 5, 2025

sebalix requested a review from jbaudoux June 5, 2025 15:42

[MIG] stock_checkout_sync: Migration to 18.0

886d6ab

sebalix force-pushed the 18-mig-stock_checkout_sync branch from 0999dd0 to 886d6ab Compare June 5, 2025 15:47

sebalix marked this pull request as ready for review June 5, 2025 15:47

sebalix mentioned this pull request Jun 6, 2025

[18.0][MIG] stock_dynamic_routing_checkout_sync #1980

Draft

ivantodorovich approved these changes Jun 9, 2025

View reviewed changes

twalter-c2c approved these changes Jun 10, 2025

View reviewed changes

OCA-git-bot added the approved label Jun 10, 2025

jbaudoux approved these changes Jun 10, 2025

View reviewed changes

OCA-git-bot added the ready to merge label Jun 10, 2025

marcelsavegnago approved these changes Jun 10, 2025

View reviewed changes

jbaudoux reviewed Jun 10, 2025

View reviewed changes

jbaudoux requested changes Jun 10, 2025

View reviewed changes

OCA-git-bot removed approved ready to merge labels Jun 10, 2025

sebalix added the work in progress label Jun 11, 2025

fixup! [MIG] stock_checkout_sync: Migration to 18.0

63fe542

sebalix removed the work in progress label Jun 12, 2025

jbaudoux reviewed Jun 16, 2025

View reviewed changes

fixup! fixup! [MIG] stock_checkout_sync: Migration to 18.0

ad0b292

jbaudoux approved these changes Jul 1, 2025

View reviewed changes

OCA-git-bot added approved ready to merge labels Jul 1, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

[18.0][MIG] stock_checkout_sync #1979

[18.0][MIG] stock_checkout_sync #1979

Uh oh!

sebalix commented Jun 5, 2025 •

edited

Loading

Uh oh!

twalter-c2c left a comment

Uh oh!

jbaudoux Jun 10, 2025

Uh oh!

OCA-git-bot commented Jun 10, 2025

Uh oh!

marcelsavegnago left a comment

Uh oh!

jbaudoux left a comment

Uh oh!

jbaudoux left a comment •

edited

Loading

Uh oh!

jbaudoux Jun 16, 2025

Uh oh!

jbaudoux left a comment

Uh oh!

OCA-git-bot commented Jul 1, 2025

Uh oh!

Uh oh!

	show_skip_button = fields.Boolean(default=False)
	show_skip_button = fields.Boolean()

Uh oh!

[18.0][MIG] stock_checkout_sync #1979

Are you sure you want to change the base?

[18.0][MIG] stock_checkout_sync #1979

Uh oh!

Conversation

sebalix commented Jun 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issue about updating locations directly on moves and on backorders

Uh oh!

twalter-c2c left a comment

Choose a reason for hiding this comment

Uh oh!

jbaudoux Jun 10, 2025

Choose a reason for hiding this comment

Uh oh!

OCA-git-bot commented Jun 10, 2025

Uh oh!

marcelsavegnago left a comment

Choose a reason for hiding this comment

Uh oh!

jbaudoux left a comment

Choose a reason for hiding this comment

Uh oh!

jbaudoux left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jbaudoux Jun 16, 2025

Choose a reason for hiding this comment

Uh oh!

jbaudoux left a comment

Choose a reason for hiding this comment

Uh oh!

OCA-git-bot commented Jul 1, 2025

Uh oh!

Uh oh!

sebalix commented Jun 5, 2025 •

edited

Loading

jbaudoux left a comment •

edited

Loading