[18.0] [FIX] stock_dynamic_routing: keep source location
#2106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @jbaudoux, |
ivantodorovich
force-pushed
the
18.0-fix-stock-dynamic-routing
branch
from
ba8b24e to
b31719e
Compare
TDu
approved these changes
Sep 19, 2025
jbaudoux
reviewed
Sep 22, 2025
Comment on lines
+291
to
+296
| # Use the source location of the routing rule, if not already done | ||
| # If a sublocation is used, it's respected. | ||
| if not move.location_id._child_of(routing_rule.location_src_id): | ||
| move.with_context( | ||
| __applying_routing_rule=True | ||
| ).location_id = routing_rule.location_src_id |
There was a problem hiding this comment.
Can you extend a test to cover this fix? Validate the pulled move and check the chain is not broken
There was a problem hiding this comment.
Sure thing, it's done!
There was a problem hiding this comment.
…y a sublocation of the routing rule src location
…location dependency
ivantodorovich
force-pushed
the
18.0-fix-stock-dynamic-routing
branch
from
b31719e to
03c21da
Compare
|
This PR has the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit is the actual fix.
The others are additional improvements, quick win opportunities