-
-
Notifications
You must be signed in to change notification settings - Fork 724
[18.0] [ADD] stock_dynamic_routing_delivery #2109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 18.0
Are you sure you want to change the base?
[18.0] [ADD] stock_dynamic_routing_delivery #2109
Conversation
Hi @jbaudoux, |
7471c5e
to
6061a39
Compare
and routing_rule.propagate_carrier | ||
and not vals.get("carrier_id") | ||
): | ||
vals["carrier_id"] = self.group_id.sale_id.carrier_id.id |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know how odoo is doing to propagate the carrier but shouldn't come from the sale. You better take it from the procurement group. There is an oca module adding it there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to copy what Odoo does for their own propagate_carrier
:
In STD there's no carrier_id
in the procurement group, we'd need an extra dependency (delivery_procurement_group_carrier
) but it makes no sense IMO
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Issue is that we do a carrier selection on the delivery. So we can't rely on the SO carrier.
I fixed the odoo rule propagation here #2110
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added also a glue module: stock_dynamic_routing_delivery_procurement_group_carrier
.
Does it make sense to you?
6061a39
to
04f0ba1
Compare
04f0ba1
to
3b5d7ce
Compare
No description provided.