Skip to content

Conversation

ivantodorovich
Copy link
Contributor

No description provided.

@OCA-git-bot
Copy link
Contributor

Hi @jbaudoux,
some modules you are maintaining are being modified, check this out!

@ivantodorovich ivantodorovich force-pushed the stock-dynamic-routing-delivery branch from 7471c5e to 6061a39 Compare September 22, 2025 18:35
@ivantodorovich ivantodorovich marked this pull request as ready for review September 22, 2025 18:42
and routing_rule.propagate_carrier
and not vals.get("carrier_id")
):
vals["carrier_id"] = self.group_id.sale_id.carrier_id.id
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know how odoo is doing to propagate the carrier but shouldn't come from the sale. You better take it from the procurement group. There is an oca module adding it there.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to copy what Odoo does for their own propagate_carrier:

In STD there's no carrier_id in the procurement group, we'd need an extra dependency (delivery_procurement_group_carrier) but it makes no sense IMO

Copy link
Contributor

@jbaudoux jbaudoux Sep 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue is that we do a carrier selection on the delivery. So we can't rely on the SO carrier.
I fixed the odoo rule propagation here #2110

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added also a glue module: stock_dynamic_routing_delivery_procurement_group_carrier.
Does it make sense to you?

@ivantodorovich ivantodorovich force-pushed the stock-dynamic-routing-delivery branch from 6061a39 to 04f0ba1 Compare September 23, 2025 11:04
@ivantodorovich ivantodorovich force-pushed the stock-dynamic-routing-delivery branch from 04f0ba1 to 3b5d7ce Compare September 23, 2025 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants