[18.0][MIG] stock_picking_import_serial_number: Migration to version 18.0 #2133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[UPD] Update stock_picking_import_serial_number.pot
You can't use a static assignation in kw args, and less the empty string, which is assigned as is on the char fields (and being different from NULL values).
Don't pass `default_code` in vals if no reference is provided, for letting other modules to work properly in integration tests like `product_code_mandatory` + `product_sequence`. stock_picking_import_serial_number 13.0.1.0.2
[UPD] Update stock_picking_import_serial_number.pot [BOT] post-merge updates
Currently translated at 100.0% (29 of 29 strings) Translation: stock-logistics-workflow-15.0/stock-logistics-workflow-15.0-stock_picking_import_serial_number Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-15-0/stock-logistics-workflow-15-0-stock_picking_import_serial_number/es/
Translated using Weblate (Italian) Currently translated at 100.0% (29 of 29 strings) Translation: stock-logistics-workflow-15.0/stock-logistics-workflow-15.0-stock_picking_import_serial_number Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-15-0/stock-logistics-workflow-15-0-stock_picking_import_serial_number/it/ Translated using Weblate (Italian) Currently translated at 100.0% (29 of 29 strings) Translation: stock-logistics-workflow-15.0/stock-logistics-workflow-15.0-stock_picking_import_serial_number Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-15-0/stock-logistics-workflow-15-0-stock_picking_import_serial_number/it/
Currently translated at 100.0% (29 of 29 strings) Translation: stock-logistics-workflow-15.0/stock-logistics-workflow-15.0-stock_picking_import_serial_number Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-15-0/stock-logistics-workflow-15-0-stock_picking_import_serial_number/it/
Adds the possibility to set the package name (stock.quant.package) in the import file to be auto-created with that name. TT47271 [UPD] Update stock_picking_import_serial_number.pot [BOT] post-merge updates Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: stock-logistics-workflow-15.0/stock-logistics-workflow-15.0-stock_picking_import_serial_number Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-15-0/stock-logistics-workflow-15-0-stock_picking_import_serial_number/
Currently translated at 100.0% (32 of 32 strings) Translation: stock-logistics-workflow-15.0/stock-logistics-workflow-15.0-stock_picking_import_serial_number Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-15-0/stock-logistics-workflow-15-0-stock_picking_import_serial_number/it/
Currently translated at 100.0% (32 of 32 strings) Translation: stock-logistics-workflow-16.0/stock-logistics-workflow-16.0-stock_picking_import_serial_number Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-16-0/stock-logistics-workflow-16-0-stock_picking_import_serial_number/it/
eduezerouali-tecnativa
force-pushed
the
18.0-mig-stock_picking_import_serial_number
branch
2 times, most recently
from
bd092ee to
06d274a
Compare
Member
|
/ocabot migration stock_picking_import_serial_number |
pedrobaeza
requested changes
Oct 14, 2025
| cls.lot_obj = cls.env["stock.lot"] | ||
| cls.warehouse = cls.env.ref("stock.warehouse0") | ||
| cls.picking_type_in = cls.env.ref("stock.picking_type_in") | ||
| cls.picking_type_in = cls.env.ref("stock.picking_type_out") |
Member
There was a problem hiding this comment.
Why changing this? We want to try on incoming receptions.
stock_picking_import_serial_number/tests/test_stock_picking_import_serial_number.py
Outdated
Show resolved
Hide resolved
| name="%(action_import_serial_number)d" | ||
| string="Import S/N" | ||
| attrs="{'invisible': ['|', ('state', '!=', 'assigned'), ('picking_type_code', '!=', 'incoming')]}" | ||
| invisible="state != 'assigned' or picking_type_code != 'incoming'" |
Contributor
Author
There was a problem hiding this comment.
@pedrobaeza it should only work at the moment whit incoming, right? Anyways i do not see why it wont work with outgoings.
Member
There was a problem hiding this comment.
With outgoing pickings, you have to check also for reservations, so there are so few steps. That's why the extra tests you removed.
eduezerouali-tecnativa
force-pushed
the
18.0-mig-stock_picking_import_serial_number
branch
2 times, most recently
from
9437904 to
926ec11
Compare
pedrobaeza
reviewed
Oct 16, 2025
| wiz.action_import() | ||
| smls = self.picking_in_01.move_line_ids.filtered("lot_name") | ||
| self.assertEqual(len(smls), 3) | ||
| self.assertEqual(len(smls), 6) |
Member
There was a problem hiding this comment.
Why this change in the numbers? This shows that the implementation is not the same...
eduezerouali-tecnativa
force-pushed
the
18.0-mig-stock_picking_import_serial_number
branch
from
926ec11 to
b414d86
Compare
eduezerouali-tecnativa
force-pushed
the
18.0-mig-stock_picking_import_serial_number
branch
from
b414d86 to
c0b4496
Compare
Contributor
Author
|
@pedrobaeza I did change test to check for outgoings. |
pedrobaeza
reviewed
Oct 21, 2025
| # TODO: Check if product is present on initial demand?? | ||
| # elif product and picking.move_lines.filtered(lambda ln: ln.product_id == product) | ||
| # elif product and picking.move_lines.filtered( | ||
| # lambda ln: ln.product_id == product) |
| ) | ||
| if picking.picking_type_id.show_reserved: | ||
| smls = stock_move_lines.filtered(lambda ln: ln.product_id == product) | ||
| if picking.picking_type_code == "incoming": |
Member
There was a problem hiding this comment.
Is this condition equivalent to the previous one?
Contributor
Author
There was a problem hiding this comment.
Actually it should be the other way around ( != ), but test keep failing. My question is if there is not show_reserved now, so everything is working as if show_reserved was false or am I missing something ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @Tecnativa TT57280
ping @victoralmau @sergio-teruel
I change the test as show_reserved is no longer available in 18.0, I did remove that part as IMHO I think it is unnecessary.