Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0][IMP] stock_weighing: open groupby record #24

Merged

Conversation

chienandalu
Copy link
Member

@chienandalu chienandalu commented Dec 16, 2024

Add an access to the groupby record (if it's a related one) to be able to access to its full info.

cc @Tecnativa TT52202

please check @sergio-teruel @carlosdauden

I'm using the core o_column_edit method but maybe it'd would be more interesting to override it and open it with ir.actions.act_window

Updated: finally using a ir.actions.act_window and a separate trigger for a more usable workflow:

Peek 16-12-2024 14-10

@chienandalu chienandalu force-pushed the 15.0-imp-stock_weighing-open-groupby-record branch from 800a300 to 97ff421 Compare December 16, 2024 13:10
Copy link
Contributor

@sergio-teruel sergio-teruel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change...
Maybe bigger icon to open the record linked?

@chienandalu chienandalu force-pushed the 15.0-imp-stock_weighing-open-groupby-record branch from 97ff421 to 10df587 Compare December 16, 2024 14:10
@chienandalu
Copy link
Member Author

@sergio-teruel How about like this?:

image

@sergio-teruel
Copy link
Contributor

Perfect!!! Great!!

Add an access to the groupby record (if it's a related one) to be able
to access to its full info.

TT52202
@chienandalu chienandalu force-pushed the 15.0-imp-stock_weighing-open-groupby-record branch from 10df587 to c803e24 Compare December 16, 2024 14:14
@chienandalu
Copy link
Member Author

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 15.0-ocabot-merge-pr-24-by-chienandalu-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 8d0a473 into OCA:15.0 Dec 17, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at f83027a. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 15.0-imp-stock_weighing-open-groupby-record branch December 17, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants