Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0][ADD] stock_secondary_unit_weighing: New module #5

Merged

Conversation

chienandalu
Copy link
Member

@chienandalu chienandalu commented Apr 18, 2024

We can go to the weighing operations from an action button in the batch
picking form.

Depends on:

cc @Tecnativa TT47127

Peek 17-04-2024 16-02

Moved from:

@chienandalu chienandalu force-pushed the 15.0-add-stock_secondary_unit_weighing branch 3 times, most recently from 5c9796a to f31aa71 Compare May 23, 2024 13:56
@chienandalu chienandalu force-pushed the 15.0-add-stock_secondary_unit_weighing branch from f31aa71 to 6b1c376 Compare July 17, 2024 09:53
@chienandalu chienandalu force-pushed the 15.0-add-stock_secondary_unit_weighing branch from 6b1c376 to 671a971 Compare September 20, 2024 07:40
@chienandalu
Copy link
Member Author

Let's merge this @sergio-teruel @carlosdauden

@sergio-teruel
Copy link
Contributor

Maybe the name could be "stock_weighing_secondary_unit"?
I'm not sure

@chienandalu
Copy link
Member Author

Maybe the name could be "stock_weighing_secondary_unit"? I'm not sure

Well, the formula we're following in the rest of extensions is extendeded_module_name+weighing

@pedrobaeza pedrobaeza added this to the 15.0 milestone Sep 20, 2024
Comment on lines 9 to 12
has_recorded_weight = fields.Boolean(help="The weight was set from the wizard")
recorded_weight = fields.Float(digits="Product Unit of Measure")
weighing_user_id = fields.Many2one(comodel_name="res.users")
weighing_date = fields.Datetime()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't get how this is tied to the secondary unit

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It hasn't. It just slipped into the code and it overwriting the original fields. Thanks for pointing out

@chienandalu chienandalu force-pushed the 15.0-add-stock_secondary_unit_weighing branch from 671a971 to fe0bac1 Compare September 20, 2024 10:40
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 15.0-ocabot-merge-pr-5-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 9b37f52 into OCA:15.0 Sep 20, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 02bbc14. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 15.0-add-stock_secondary_unit_weighing branch September 20, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants