Skip to content

[18.0][IMP] fs_storage: Allow setting check_connection_method in configuration file #485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 18.0
Choose a base branch
from

Conversation

vincent-hatakeyama
Copy link
Contributor

Port of #442 to 18.0

Copy link
Member

@etobella etobella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Making this change will loose the data from the instance, as the system will drop the column check_connection_method.

At least we need a migration script. The same might happen with the original version.

@vincent-hatakeyama vincent-hatakeyama force-pushed the feature/18.0/fs_storage/allow_setting_check_connection_method_server_env branch from 537b5aa to ed974b1 Compare July 3, 2025 08:48
@vincent-hatakeyama
Copy link
Contributor Author

At least we need a migration script. The same might happen with the original version.

I’ve added an update script.

@vincent-hatakeyama vincent-hatakeyama force-pushed the feature/18.0/fs_storage/allow_setting_check_connection_method_server_env branch from ed974b1 to 5e47127 Compare July 3, 2025 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants