Skip to content

[16.0][IMP] hr_timesheet_name_customer: Show "Description Customer" in portal #742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 16.0
Choose a base branch
from

Conversation

ivs-cetmix
Copy link
Member

@ivs-cetmix ivs-cetmix commented Feb 21, 2025

Show "Description Customer" in portal instead of "Description". This is done to maintain consistency and show the same information in all views and reports.
Otherwise a client can be confused by seeing different descriptions in reports and portal.

Add a post-init hook to populate "Description Customer" with "Description" for existing records if it is not set.
This is done to ensure that the "Description Customer" field is not empty.

Remove maintainers as we don't maintain OCA modules any longer.

@OCA-git-bot
Copy link
Contributor

Hi @solo4games, @CetmixGitDrone,
some modules you are maintaining are being modified, check this out!

@ivs-cetmix ivs-cetmix force-pushed the 16.0-t4362-hr_timesheet_name_customer-portal branch from a82a6a0 to 5ba2196 Compare February 21, 2025 18:11
Copy link

@mike-cetmix mike-cetmix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Show "Description Customer" in portal instead of "Description".
This is done to maintain consistency and show the same information
in all views and reports.
Otherwise a client can be confused by seeing different descriptions in
reports and portal.

Add a post-init hook to populate "Description Customer" with "Description"
for existing records if it is not set.
This is done to ensure that the "Description Customer" field is not empty.
@ivs-cetmix ivs-cetmix force-pushed the 16.0-t4362-hr_timesheet_name_customer-portal branch from 5ba2196 to 26337ac Compare March 26, 2025 18:30
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants