Skip to content

[MIG] website_local_font: Migration to 16.0 #1051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: 16.0
Choose a base branch
from
Open

[MIG] website_local_font: Migration to 16.0 #1051

wants to merge 3 commits into from

Conversation

Reyes4711-S73
Copy link

@Reyes4711-S73 Reyes4711-S73 commented Aug 5, 2024 •
edited
Loading

Standard migration to 16.0
Reopen from #1028

@Reyes4711-S73 Reyes4711-S73 changed the title 16.016.0 mig website local font def [MIG] website_local_font: Migration to 16.0 Aug 5, 2024
@Reyes4711-S73 Reyes4711-S73 force-pushed the 16.016.0-mig-website_local_font-def branch from b097857 to 4a24839 Compare August 5, 2024 06:12
@ioans73 ioans73 mentioned this pull request Sep 10, 2024
Closed
@pedrobaeza
Copy link
Member

/ocabot migration website_local_font

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Sep 11, 2024
xaviedoanhduy
xaviedoanhduy reviewed Sep 27, 2024
View reviewed changes
@Reyes4711-S73 Reyes4711-S73 force-pushed the 16.016.0-mig-website_local_font-def branch from 4a24839 to 84f2984 Compare September 30, 2024 07:16
@Reyes4711-S73
Copy link
Author

@xaviedoanhduy Done

xaviedoanhduy
xaviedoanhduy approved these changes Sep 30, 2024
View reviewed changes
Copy link

@xaviedoanhduy xaviedoanhduy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the above changes

@OCA-git-bot OCA-git-bot mentioned this pull request Sep 11, 2024
Open
13 tasks
@Christian-RB
Copy link

Thanks for this @Reyes4711-S73 , do you mind rebasing so we can test it on runboat?

@Reyes4711-S73 Reyes4711-S73 force-pushed the 16.016.0-mig-website_local_font-def branch 3 times, most recently from f01dfab to a9b0f21 Compare January 29, 2025 14:13
Christian-RB
Christian-RB approved these changes Jan 29, 2025
View reviewed changes
Copy link

@Christian-RB Christian-RB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and functional review OK.
Please add the versión to the PR title [16.0][MIG] website_local_font: Migration to 16.0
Thanks for the fast response 😄

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@Abimael1321
Copy link

LGTM! It allows you to import local fonts that are not from Google, the only aspect I detected is that it duplicates and adds the Google fonts, which is already included in Odoo.
Screenshot_1

AlvaroRM11
AlvaroRM11 suggested changes Jan 30, 2025
View reviewed changes
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 1, 2025

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jun 1, 2025
@Reyes4711-S73 Reyes4711-S73 force-pushed the 16.016.0-mig-website_local_font-def branch from a9b0f21 to 81c70e9 Compare June 2, 2025 05:54
@Reyes4711-S73
Copy link
Author

@OCA/website-maintainers could anyone merge this PR?

@tarteo
Copy link
Member

tarteo commented Jun 3, 2025 •
edited
Loading

@Reyes4711-S73 Can you rebase your branch with latest commits from https://github.com/OCA/website please

bvanjeelharia and others added 3 commits June 6, 2025 09:29
@bvanjeelharia @Reyes4711-S73
[ADD] website_local_fonts: add new module
981a67f 
[ADD] website_local_fonts: add new module

[ADD] website_local_fonts: add new module

Updated Test Folder Name

Changes as per suggestions in the PR

Added missing setup file
@Reyes4711-S73
[IMP] website_local_font: pre-commit stuff
7368455
@Reyes4711-S73
[MIG] website_local_font: Migration to 16.0
5c2d6e2
@Reyes4711-S73 Reyes4711-S73 force-pushed the 16.016.0-mig-website_local_font-def branch from 81c70e9 to 5c2d6e2 Compare June 6, 2025 07:29
@Reyes4711-S73
Copy link
Author

@tarteo Done

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jun 8, 2025
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

tarteo
tarteo requested changes Jun 10, 2025
View reviewed changes
Copy link
Member

@tarteo tarteo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on runboat

I tried otf and ttf files, but only ttf worked.

Seems that I can only have one local font at a time and I cannot remove it which the screenshots (website_local_font/static/description/NewlyAddedFont.png) suggests it was possible in previous versions.

(non-blocking issue) the font won't be applied in the editor after saving. I need to refresh it
after save:
image
after refresh:
image

It says it's served by google (the blue cloud icon) which is not the case for local fonts.

Vicent-S73 pushed a commit to Studio73/e-commerce that referenced this pull request Aug 12, 2025
@Reyes4711-S73 @ioans73
feat(odoo): add OCA/website#1051
06258ce
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarteo tarteo tarteo requested changes

@Christian-RB Christian-RB Christian-RB approved these changes

@xaviedoanhduy xaviedoanhduy xaviedoanhduy approved these changes

@AlvaroRM11 AlvaroRM11 AlvaroRM11 approved these changes

@Abimael1321 Abimael1321 Abimael1321 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
9 participants
@Reyes4711-S73 @pedrobaeza @Christian-RB @OCA-git-bot @Abimael1321 @tarteo @xaviedoanhduy @AlvaroRM11 @bvanjeelharia