-
-
Notifications
You must be signed in to change notification settings - Fork 716
[18.0][MIG] website_cookiebot: Migration to 18.0 #1093
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
StefanRijnhart
wants to merge
12
commits into
OCA:18.0
Choose a base branch
from
StefanRijnhart:18.0-mig-website_cookiebot
base: 18.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[18.0][MIG] website_cookiebot: Migration to 18.0 #1093
StefanRijnhart
wants to merge
12
commits into
OCA:18.0
from
StefanRijnhart:18.0-mig-website_cookiebot
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
StefanRijnhart
commented
Mar 10, 2025
- Align config layout with similar settings on the same page
- Renew screenshot in description
- Reorganize templates. - Make templates noupdate=0, because if user edits them, it will be in the COW'd, website-specific version, so no problem on that. - Rename `cookiebot_id` to `cookiebot_dgid` to avoid confusion with X2many fields. - Remove ICP support, as the DGID should be per website. - Add ID placeholders to Cookie Declaration page editable sections. - Ensure Google Analytic script is blocked before consenting statistics. FTR it wasn't actually being blocked. - Improve instructions. - Split README. - Apply pre-commit. @Tecnativa TT32828
Currently translated at 100.0% (13 of 13 strings) Translation: website-16.0/website-16.0-website_cookiebot Translate-URL: https://translation.odoo-community.org/projects/website-16-0/website-16-0-website_cookiebot/es/
If we don't remove the key the assets will keep trying to load, which isn't what we'd expect. TT50520
* Align config layout with similar settings on the same page * Renew screenshot in description
6ba9bf6
to
ce77ae6
Compare
/ocabot migration website_cookiebot |
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.