Skip to content

[FIX] website_require_login: Error response #1099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 16.0
Choose a base branch
from

Conversation

Alexgars73
Copy link
Contributor

Error in response in first load:
image

Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jul 27, 2025
@Alexgars73
Copy link
Contributor Author

Alexgars73 commented Jul 28, 2025

@pedrobaeza could you remove the stale tag please?

@pedrobaeza pedrobaeza removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Aug 1, 2025
@pedrobaeza pedrobaeza added this to the 16.0 milestone Aug 1, 2025
@pedrobaeza
Copy link
Member

OK, but please enroll people to review it.

@Alexgars73
Copy link
Contributor Author

Alexgars73 commented Aug 1, 2025

@yvaucher @NICO-SOLUTIONS could you review please?

Copy link
Member

@NICO-SOLUTIONS NICO-SOLUTIONS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Havent seen this effect up to now but it makes sense!
in generel i would place the check for Content-Type == "application/json" before assigning the redirect_path. but thats academic.

LGTM!

@Alexgars73 Alexgars73 force-pushed the 16.0-fix-website_require_login branch from b83fa59 to c5c4a3e Compare August 6, 2025 10:11
@Alexgars73 Alexgars73 force-pushed the 16.0-fix-website_require_login branch from c5c4a3e to 58037bf Compare August 6, 2025 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants