-
-
Notifications
You must be signed in to change notification settings - Fork 716
[17.0][MIG] website_recaptcha_v2 #1102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
edescalona
wants to merge
18
commits into
OCA:17.0
Choose a base branch
from
BinhexTeam:17.0-mig-website_recaptcha_v2
base: 17.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e01e470
to
c0b638d
Compare
This was referenced Apr 21, 2025
rrebollo
reviewed
May 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review. LGTM!
rename website_recaptcha_reloaded to website_recaptcha_v2.
* add recaptcha widget view. * allow to enable and disable recaptcha in settings. * improve settings view. * change arguments and return value of website.is_captcha_valid(): it now takes a form values dictionary as argument instead of a string and returns a tuple containing a boolean value and an error message instead of raising an exception. * add tests.
* add recaptcha test keys as demo data. * improve manifest and readme. * use correct names for files, classes and xml ids.
Co-authored-by: hugues de keyzer <[email protected]>
set recaptcha script loading as async to prevent it from blocking the page rendering.
Currently translated at 100.0% (19 of 19 strings) Translation: website-16.0/website-16.0-website_recaptcha_v2 Translate-URL: https://translation.odoo-community.org/projects/website-16-0/website-16-0-website_recaptcha_v2/it/
c0b638d
to
d960b66
Compare
rrebollo
approved these changes
Jun 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review. LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@BinhexTeam
Standard migration.