[FP][IMP] website_cookiefirst: Replace deprecated Cookiefirst functionality

[NICO-SOLUTIONS]

• replace banner.js with new consent.js script using domain and identifier
• forward ported from V17 PR ([IMP] website_cookiefirst: Replace deprecated Cookiefirst functionality #1110)

[NICO-SOLUTIONS]

@eugenios73
@matteoopenf
hey. sorry for bothering again.
we needed to cover www domains as well, which was considered up to now.
Are you willing to review the changes again?

[NICO-SOLUTIONS]

@ioans73 added the fix in this existing fowardport.

[eugenios73]

LGTM

[OCA-git-bot]

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

[NICO-SOLUTIONS]

@OCA/website-maintainers
can we merge this one please?

[pedrobaeza]

You have to squash commits and use proper commit message:

https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#commit-message

[pedrobaeza]

And next time, it's better that you do only a pull request for one version, and when merged, then do the fw-ports, as if not, any change have to be propagated to each of the PRs, giving you more work, and adding noise to the email subscribers.

[matteoopenf]

technical review is ok

[NICO-SOLUTIONS]

And next time, it's better that you do only a pull request for one version, and when merged, then do the fw-ports, as if not, any change have to be propagated to each of the PRs, giving you more work, and adding noise to the email subscribers.

@pedrobaeza
ok. thanks for the hint. i am not 100% aware of the forward and backport mechanism. I will get into it...
Concerning the squashing. you mean the two commits inhere? The imp commit is already merged into 17.. thats why i ask.
and sorry for the noise.

[pedrobaeza]

Yes, in this version 18, there's no need to keep both things as separated, as I understand that both belongs to the same concept: replace deprecated functionality. In 17, as one patch was already merged, there's no other solution than to add an extra commit, but here, we can keep the commit history clean.