Skip to content

Conversation

@rousseldenis
Copy link

These modules allow to build base bricks to support printing

@rousseldenis rousseldenis added this to the 16.0 milestone Jul 17, 2025
@rousseldenis rousseldenis force-pushed the 16.0-add-shopfloor_mobile_printing_base-dro branch from 7b2ac59 to 1c01ec6 Compare July 17, 2025 08:44
@rousseldenis rousseldenis force-pushed the 16.0-add-shopfloor_mobile_printing_base-dro branch from 1c01ec6 to dbb532e Compare July 17, 2025 09:02
@@ -0,0 +1,113 @@
/**
* Copyright 2020 Camptocamp SA (http://www.camptocamp.com)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

leftover :)

* License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl.html).
*/

export var LabelPrinterWidget = Vue.component("label-printer", {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not improving the input-number-spinner widget?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hesitated


_inherit = "base.shopfloor.service"

def _printing_for(self, usage):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand what is it used for

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is needed to get the printing component on flows ones (reception, ...). This allows to reuse a certain logic and also to get specific ones when needed

"""
Returns the report to print
"""
return self.work.menu.label_print_report_id

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO instead of relying on a fixed report per menu item, we should pass this id into the menu data for the frontend and then the frontend will pas the id of the report to print. This way, the endpoint will work with any report.
Then I don't think we need this endpoint at all since we could use the standard endpoint for printing reports or a similar one.
Just ensure that you can pass the config to the menu or to the scenario.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you elaborate ? What do you mean by into the menu data ?

@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Nov 16, 2025
@github-actions github-actions bot closed this Dec 21, 2025
@rousseldenis rousseldenis reopened this Dec 22, 2025
@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Dec 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants