-
-
Notifications
You must be signed in to change notification settings - Fork 209
[16.0][ADD] shopfloor_priting_base/mobile #1085
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 16.0
Are you sure you want to change the base?
[16.0][ADD] shopfloor_priting_base/mobile #1085
Conversation
7b2ac59 to
1c01ec6
Compare
1c01ec6 to
dbb532e
Compare
| @@ -0,0 +1,113 @@ | |||
| /** | |||
| * Copyright 2020 Camptocamp SA (http://www.camptocamp.com) | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
leftover :)
| * License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl.html). | ||
| */ | ||
|
|
||
| export var LabelPrinterWidget = Vue.component("label-printer", { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not improving the input-number-spinner widget?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hesitated
|
|
||
| _inherit = "base.shopfloor.service" | ||
|
|
||
| def _printing_for(self, usage): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand what is it used for
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is needed to get the printing component on flows ones (reception, ...). This allows to reuse a certain logic and also to get specific ones when needed
| """ | ||
| Returns the report to print | ||
| """ | ||
| return self.work.menu.label_print_report_id |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO instead of relying on a fixed report per menu item, we should pass this id into the menu data for the frontend and then the frontend will pas the id of the report to print. This way, the endpoint will work with any report.
Then I don't think we need this endpoint at all since we could use the standard endpoint for printing reports or a similar one.
Just ensure that you can pass the config to the menu or to the scenario.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you elaborate ? What do you mean by into the menu data ?
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
These modules allow to build base bricks to support printing