[16.0][IMP] stock_available_to_promise_release: Improved release process ro… #939
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmignon
force-pushed
the
16.0-stock_available_to_promise_release-release-robustness
branch
from
581644f to
5bf5e2c
Compare
Author
lmignon
force-pushed
the
16.0-stock_available_to_promise_release-release-robustness
branch
from
5bf5e2c to
56bd545
Compare
…bustness Previous to this change, if the release process was 'forced' multiple time on an already released move, the system issued new procumrement rules without thaking into account the qty already released or processed. As side effect, the qty into the picking operation was higher than the expected qty to deliver. We now take into account the qty already released into the release process
lmignon
force-pushed
the
16.0-stock_available_to_promise_release-release-robustness
branch
from
56bd545 to
6713cde
Compare
sbejaoui
approved these changes
Oct 29, 2024
jbaudoux
requested changes
Dec 31, 2024
Contributor
jbaudoux
left a comment
jbaudoux
left a comment
There was a problem hiding this comment.
This complexity should not be necessary because by definition a move is either in need_release or not. When in need_release, the qty to release is the product_uom_qty, and when not in need_release there is nothing to release.
This looks like a workaround for a bug non identified.
Not requesting changes, just not in favor of merging this
6 tasks
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…bustness
Previous to this change, if the release process was 'forced' multiple time on an already released move, the system issued new procumrement rules without thaking into account the qty already released or processed. As side effect, the qty into the picking operation was higher than the expected qty to deliver. We now take into account the qty already released into the release process