Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][FIX] shopfloor: compatibility location barcode with barcodes_generator_location #947

Open
wants to merge 1 commit into
base: 14.0
Choose a base branch
from

Conversation

clementmbr
Copy link
Member

@clementmbr clementmbr commented Nov 15, 2024

When using wms/shopfloor with stock-logistics-barcode/barcodes_generator_location, the location's view is getting unusable because the module barcodes_generator_location is awaiting to have the barcode field in a dedicated group like in stock-logistics-barcode/stock_barcodes :
image

This PR creates a dedicated group for the barcode field, making the 2 modules shopfloor and barcodes_generator_location compatible:
image

cc @Kev-Roche

@OCA-git-bot
Copy link
Contributor

Hi @sebalix, @simahawk, @guewen,
some modules you are maintaining are being modified, check this out!

@clementmbr clementmbr force-pushed the 14.0-fix-shopfloor-barcode branch from 9c3a10c to e1df91a Compare November 15, 2024 16:57
@clementmbr clementmbr marked this pull request as ready for review November 15, 2024 16:58
@clementmbr clementmbr force-pushed the 14.0-fix-shopfloor-barcode branch from e1df91a to 794466b Compare November 15, 2024 17:02
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Mar 16, 2025
@sebalix
Copy link
Contributor

sebalix commented Mar 17, 2025

Thanks for your PR.
IMO what we are missing here is a simple module stock_location_barcode with this change, and make it a dependency of both shopfloor and stock_barcodes.

Checked in 18.0: barcode field still not re-introduced on std view.

@sebalix sebalix added needs fixing and removed stale PR/Issue without recent activity, it'll be soon closed automatically. labels Mar 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants