Add a brightness offset option #5
Conversation
A slider that can offset the synced value by +/- 50%. This enables the user to manually sync up the apparent brightness when the displays have a different brightness range. Also: - parametrizes the update interval - schedules the updated timer in the common runloop mode so updates happen while interacting with the app - removes empty whitespace
|
|
||
|
|
||
| let brightnessOffsetKey = "BSBrightnessOffset" | ||
| var brightnessOffset: Double { |
There was a problem hiding this comment.
Perhaps having a different default value than 0 would be more appropriate. I'm using about -20% / - 25% to match up my MBP and the LG. On the other hand, this means the display is automatically deprived of it's max brightness, which somebody might not like. So 0 might be the safer option.
There was a problem hiding this comment.
I'll go with 0. This should also be the correct setting for users still on Mojave.
| let menu = NSMenu() | ||
| menu.addItem(statusIndicator) | ||
| menu.addItem(NSMenuItem.separator()) | ||
|
|
||
|
|
||
| menu.addItem(NSMenuItem(title: "Brightness Offset", action: nil, keyEquivalent: "")) |
There was a problem hiding this comment.
Open for suggestions for a better name for this. 🤷♂
There was a problem hiding this comment.
Hmm, can't think of any. I also wish I had a better name for the app than “Brightness Sync”...
| @@ -88,7 +107,8 @@ class AppDelegate: NSObject, NSApplicationDelegate { | |||
| self.lastSaneBrightness = newBrightness | |||
| } | |||
| } | |||
|
|
|||
| RunLoop.current.add(syncTimer!, forMode: .common) | |||
There was a problem hiding this comment.
Enables brightness adjustments while interacting with the slider.
| container.addSubview(statusSlider) | ||
| statusSlider.translatesAutoresizingMaskIntoConstraints = false | ||
|
|
||
| statusSlider.leadingAnchor.constraint(equalTo: container.leadingAnchor, constant: 20).isActive = true |
There was a problem hiding this comment.
Is there a better way to match up the slider to the text, than using a magic number (20) here?
There was a problem hiding this comment.
I searched for it, but can't find anything. I made a screenshot of the system menu Volume slider and counted the pixels, so I'm going to just copy those measurements 😬
|
I merged this and I'll make some small adjustments on top. |
A slider that can offset the synced value by +/- 50%. This enables the user to manually sync up the apparent brightness when the displays have a different brightness range.
Also:
Fixes #4