Check the status of SatML in Satml_frontend #1294
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As explained in the issue OCamlPro#1293, Satml_frontend does not send to SatML a formula already present in its lazy cnf. In particular, `assume` and `unsat` of `Satml_frontend` can answer `unknown` for obviously unsat environment. After this commit, we always check the status of SatML in `assume` and `unsat`. If the solver is already unsat, the command `unsat` should return the unsat core. As SatML does not yet support this feature, I returned an empty explanation.
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As explained in the issue #1293, Satml_frontend does not send to SatML a formula already present in its lazy cnf. In particular,
assumeandunsatofSatml_frontendcan answerunknownfor obviously unsat environment. After this commit, we always check the status of SatML inassumeandunsat.If the solver is already unsat, the command
unsatshould return the unsat core. As SatML does not yet support this feature, I returned an empty explanation.This PR fixes #1293