Reorganize builtin internalization by theory #1332
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bclement-ocp
force-pushed
the
push-xumuxtvtvxxy
branch
2 times, most recently
from
cfcda44 to
8848254
Compare
Halbaroth
approved these changes
Sep 8, 2025
bclement-ocp
force-pushed
the
push-xumuxtvtvxxy
branch
4 times, most recently
from
c746095 to
6be048a
Compare
And add it to the lockfile, so that the workflows that use a lock file can build (:
Follow Dolmen's new organization of builtins by theory to ensure we don't accidentally forget builtins by leveraging OCaml's pattern-matching exhaustiveness check.
bclement-ocp
force-pushed
the
push-xumuxtvtvxxy
branch
from
6be048a to
366a1a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow Dolmen's new organization of builtins by theory to ensure we don't accidentally forget builtins by leveraging OCaml's pattern-matching exhaustiveness check.
This PR is based on, and includes, #1331