Fix detection of Let vs LetIn after a 'struct'#324
Merged
NathanReb merged 2 commits intoOCamlPro:masterfrom Sep 22, 2025
Merged
Fix detection of Let vs LetIn after a 'struct'#324NathanReb merged 2 commits intoOCamlPro:masterfrom
NathanReb merged 2 commits intoOCamlPro:masterfrom
Conversation
Merged
An indented `let` inside a `struct ... end` was incorrectly interpreted as a `LetIn`.
NathanReb
force-pushed
the
struct-let
branch
from
c20e63c to
363a9d2
Compare
NathanReb
approved these changes
Sep 22, 2025
Contributor
NathanReb
left a comment
NathanReb
left a comment
There was a problem hiding this comment.
Sorry for the 2.5 years delay and thanks for the fix!
I took the liberty to rebase your branch. I'm just waiting for the CI to go green and I'll merge!
NathanReb
pushed a commit
to Julow/ocp-indent
that referenced
this pull request
Sep 22, 2025
Signed-off-by: Nathan Rebours <[email protected]>
Contributor
Author
|
Thanks! |
NathanReb
pushed a commit
to NathanReb/opam-repository
that referenced
this pull request
Oct 1, 2025
CHANGES: + Fix detection of let vs letin after a struct (OCamlPro/ocp-indent#324, @Julow) + Treat `|>` as a monadic operator (OCamlPro/ocp-indent#322, @nberth) + Prevent Args out of range error in ocp-indent-buffer (OCamlPro/ocp-indent#327, @bcc32) + Fix "Missing ‘lexical-binding’ cookie" warning in Emacs (OCamlPro/ocp-indent#329, @nojb) + Fix a bug where ocp-indent translate LF to CRLF when run on Windows instead of preserving the input's newlines. (OCamlPro/ocp-indent#334, @nojb) + Add `ocp-indent-gen-rules` to support `dune fmt` like workflow with ocp-indent (OCamlPro/ocp-indent#333, @NathanReb)
nojb
added a commit
to LexiFi/ocp-indent
that referenced
this pull request
Feb 9, 2026
Release 1.9.0 CHANGES: + Fix detection of let vs letin after a struct (OCamlPro#324, @Julow) + Treat `|>` as a monadic operator (OCamlPro#322, @nberth) + Prevent Args out of range error in ocp-indent-buffer (OCamlPro#327, @bcc32) + Fix "Missing ‘lexical-binding’ cookie" warning in Emacs (OCamlPro#329, @nojb) + Fix a bug where ocp-indent translate LF to CRLF when run on Windows instead of preserving the input's newlines. (OCamlPro#334, @nojb) + Add `ocp-indent-gen-rules` to support `dune fmt` like workflow with ocp-indent (OCamlPro#333, @NathanReb)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An indented
letinside astruct ... endwas incorrectly interpreted as aLetIn.Same motivation as in #323. The indentation of
funis different inside aLetand aLetIn.